linux-kernel - Re: [RFC/PATCH 01/38] perf tools: Use a software dummy event to track task/mmap events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151006083105.GA24254@danjae.theccd.local>
Date:	Tue, 6 Oct 2015 17:31:05 +0900
From:	Namhyung Kim <namhyung@...nel.org>
To:	Jiri Olsa <jolsa@...hat.com>
Cc:	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Ingo Molnar <mingo@...nel.org>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	LKML <linux-kernel@...r.kernel.org>,
	Frederic Weisbecker <fweisbec@...il.com>,
	Stephane Eranian <eranian@...gle.com>,
	David Ahern <dsahern@...il.com>,
	Andi Kleen <andi@...stfloor.org>,
	Adrian Hunter <adrian.hunter@...el.com>
Subject: Re: [RFC/PATCH 01/38] perf tools: Use a software dummy event to
 track task/mmap events

Hi Jiri,

On Mon, Oct 05, 2015 at 02:51:37PM +0200, Jiri Olsa wrote:
> On Fri, Oct 02, 2015 at 02:18:42PM +0900, Namhyung Kim wrote:
> 
> SNIP
> 
> >  
> > +/**
> > + * perf_evsel__is_dummy_tracking - Return whether given evsel is a dummy
> > + * event for tracking meta events only
> > + *
> > + * @evsel - evsel selector to be tested
> > + *
> > + * Return %true if event is a dummy tracking event
> > + */
> > +static inline bool perf_evsel__is_dummy_tracking(struct perf_evsel *evsel)
> > +{
> > +	return evsel->attr.type == PERF_TYPE_SOFTWARE &&
> > +		evsel->attr.config == PERF_COUNT_SW_DUMMY &&
> > +		evsel->attr.task == 1 && evsel->attr.mmap == 1;
> 
> should this use now check for evsel->tracking ?

Originally I think it need to differentiate the dummy tracking events
and possible other dummy events.  But it seems no need to do it.  So
yes, maybe I can just check the tracking bit.

Anyway, I need to check the Intel PT code as Adrian said it might have
multiple tracking events.

Thanks,
Namhyung
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/