linux-kernel - [PATCH] gpio: make GPIO_OMAP bool instead of tristate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1444132871-25798-1-git-send-email-sudipm.mukherjee@gmail.com>
Date:	Tue,  6 Oct 2015 17:31:11 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Linus Walleij <linus.walleij@...aro.org>,
	Alexandre Courbot <gnurou@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Tony Lindgren <tony@...mide.com>,
	Austin Schuh <austin@...oton-tech.com>,
	Grygorii Strashko <grygorii.strashko@...com>,
	Santosh Shilimkar <ssantosh@...nel.org>
Subject: [PATCH] gpio: make GPIO_OMAP bool instead of tristate

While building arm allmodconfig the build fails with the error:
ERROR: "handle_bad_irq" [drivers/gpio/gpio-omap.ko] undefined!

The build breaks as handle_bad_irq is not exported for module use.

Fixes: 450fa54cfd66 ("gpio: omap: convert to use generic irq handler")
Cc: Tony Lindgren <tony@...mide.com>
Cc: Austin Schuh <austin@...oton-tech.com>
Cc: Grygorii Strashko <grygorii.strashko@...com>
Cc: Santosh Shilimkar <ssantosh@...nel.org>
Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
---

Same problem for pinctrl was fixed by
5ba341604a054294aeb812603349bba024d716ee

And for your reference:
https://lkml.org/lkml/2014/2/25/278

 drivers/gpio/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/gpio/Kconfig b/drivers/gpio/Kconfig
index 63000b1..d910fd1 100644
--- a/drivers/gpio/Kconfig
+++ b/drivers/gpio/Kconfig
@@ -330,7 +330,7 @@ config GPIO_OCTEON
 	  family of SOCs.
 
 config GPIO_OMAP
-	tristate "TI OMAP GPIO support" if ARCH_OMAP2PLUS || COMPILE_TEST
+	bool "TI OMAP GPIO support" if ARCH_OMAP2PLUS || COMPILE_TEST
 	default y if ARCH_OMAP
 	depends on ARM
 	select GENERIC_IRQ_CHIP
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/