lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 6 Oct 2015 15:18:05 +0300 From: Roger Quadros <rogerq@...com> To: Tony Lindgren <tony@...mide.com>, <linux-kernel@...r.kernel.org> CC: <linux-omap@...r.kernel.org> Subject: Re: [PATCH] memory: omap-gpmc: Fix unselectable debug option for GPMC On 06/10/15 15:13, Tony Lindgren wrote: > Commit 63aa945b1013 ("memory: omap-gpmc: Add Kconfig option for debug") > added a debug option for GPMC, but somehow managed to keep it unselectable. > > This probably happened because I had some uncommitted changes and the > GPMC option is selected in the platform specific Kconfig. > > Let's also update the description a bit, it does not mention that > enabling the debug option also disables the reset of GPMC controller > during the init as pointed out by Uwe Kleine-König > <u.kleine-koenig@...gutronix.de>. > > Fixes: 63aa945b1013 ("memory: omap-gpmc: Add Kconfig option for debug") > Reported-by: Uwe Kleine-König <u.kleine-koenig@...gutronix.de> > Signed-off-by: Tony Lindgren <tony@...mide.com> Acked-by: Roger Quadros <rogerq@...com> > --- > drivers/memory/Kconfig | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > --- a/drivers/memory/Kconfig > +++ b/drivers/memory/Kconfig > @@ -58,12 +58,13 @@ config OMAP_GPMC > memory drives like NOR, NAND, OneNAND, SRAM. > > config OMAP_GPMC_DEBUG > - bool > + bool "Enable GPMC debug output and skip reset of GPMC during init" > depends on OMAP_GPMC > help > Enables verbose debugging mostly to decode the bootloader provided > - timings. Enable this during development to configure devices > - connected to the GPMC bus. > + timings. To preserve the bootloader provided timings, the reset > + of GPMC is skipped during init. Enable this during development to > + configure devices connected to the GPMC bus. > > config MVEBU_DEVBUS > bool "Marvell EBU Device Bus Controller" > -- cheers, -roger -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists