lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 6 Oct 2015 16:02:56 +0200 From: Christophe Leroy <christophe.leroy@....fr> To: Scott Wood <scottwood@...escale.com> Cc: Benjamin Herrenschmidt <benh@...nel.crashing.org>, Paul Mackerras <paulus@...ba.org>, Michael Ellerman <mpe@...erman.id.au>, linux-kernel@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org Subject: Re: [PATCH v2 07/25] powerpc32: refactor x_mapped_by_bats() and x_mapped_by_tlbcam() together Le 29/09/2015 01:47, Scott Wood a écrit : > On Tue, Sep 22, 2015 at 06:50:42PM +0200, Christophe Leroy wrote: >> x_mapped_by_bats() and x_mapped_by_tlbcam() serve the same kind of >> purpose, so lets group them into a single function. >> >> Signed-off-by: Christophe Leroy <christophe.leroy@....fr> >> --- >> No change in v2 >> >> arch/powerpc/mm/pgtable_32.c | 33 ++++++++++++++++++++++++++------- >> 1 file changed, 26 insertions(+), 7 deletions(-) >> >> diff --git a/arch/powerpc/mm/pgtable_32.c b/arch/powerpc/mm/pgtable_32.c >> index 03a073a..3fd9083 100644 >> --- a/arch/powerpc/mm/pgtable_32.c >> +++ b/arch/powerpc/mm/pgtable_32.c >> @@ -67,6 +67,28 @@ extern unsigned long p_mapped_by_tlbcam(phys_addr_t pa); >> #define p_mapped_by_tlbcam(x) (0UL) >> #endif /* HAVE_TLBCAM */ >> >> +static inline unsigned long p_mapped_by_other(phys_addr_t pa) >> +{ >> + unsigned long v; >> + >> + v = p_mapped_by_bats(pa); >> + if (v /*&& p_mapped_by_bats(p+size-1)*/) >> + return v; >> + >> + return p_mapped_by_tlbcam(pa); >> +} > Did you forget to remove that comment? > > No I didn't, I though it was there for a reason, it has been there since 2005. Do you think I should remove it ? Christophe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists