linux-kernel - Re: [PATCH] wdt: intel-mid: add Magic Closure flag

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <561313EC.4060105@roeck-us.net>
Date:	Mon, 5 Oct 2015 17:21:00 -0700
From:	Guenter Roeck <linux@...ck-us.net>
To:	David Cohen <david.a.cohen@...ux.intel.com>, wim@...ana.be
Cc:	linux-watchdog@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] wdt: intel-mid: add Magic Closure flag

On 10/05/2015 04:49 PM, David Cohen wrote:
> Adding WDIOF_MAGICCLOSE to Intel MID watchdog driver. Once the watchdog
> is opened, it makes sense to disable watchdog only if it was gracefully
> released.
>
> Signed-off-by: David Cohen <david.a.cohen@...ux.intel.com>

Makes sense.

Reviewed-by: Guenter Roeck <linux@...ck-us.net>

> ---
>   drivers/watchdog/intel-mid_wdt.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/watchdog/intel-mid_wdt.c b/drivers/watchdog/intel-mid_wdt.c
> index 0a436b5d1e84..db36d12e2b52 100644
> --- a/drivers/watchdog/intel-mid_wdt.c
> +++ b/drivers/watchdog/intel-mid_wdt.c
> @@ -101,7 +101,7 @@ static irqreturn_t mid_wdt_irq(int irq, void *dev_id)
>
>   static const struct watchdog_info mid_wdt_info = {
>   	.identity = "Intel MID SCU watchdog",
> -	.options = WDIOF_KEEPALIVEPING | WDIOF_SETTIMEOUT,
> +	.options = WDIOF_KEEPALIVEPING | WDIOF_SETTIMEOUT | WDIOF_MAGICCLOSE,
>   };
>
>   static const struct watchdog_ops mid_wdt_ops = {
>

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/