lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Tue, 6 Oct 2015 17:08:29 +0200 From: Marcin Wojtas <mw@...ihalf.com> To: Gregory CLEMENT <gregory.clement@...e-electrons.com> Cc: linux-kernel@...r.kernel.org, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-mmc@...r.kernel.org" <linux-mmc@...r.kernel.org>, Ulf Hansson <ulf.hansson@...aro.org>, Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>, Andrew Lunn <andrew@...n.ch>, Jason Cooper <jason@...edaemon.net>, Thomas Petazzoni <thomas.petazzoni@...e-electrons.com>, nadavh@...vell.com, Lior Amsalem <alior@...vell.com>, Tawfik Bayouk <tawfik@...vell.com>, Grzegorz Jaszczyk <jaz@...ihalf.com> Subject: Re: [PATCH 4/8] mmc: sdhci-pxav3: enable proper resuming on Armada 38x SoC Gregory, 2015-10-06 16:51 GMT+02:00 Gregory CLEMENT <gregory.clement >> + if (of_device_is_compatible(np, "marvell,armada-380-sdhci")) >> + ret = mv_conf_mbus_windows(dev, pxa->mbus_win_regs, >> + mv_mbus_dram_info()); > > I would find it cleaner to not rely on the device tree outise the probe > function. What about just testing pxa->mbus_win_regs ? As it is set only > if we need it, it should be a good test. > Sure, it will ease calling the function. Thanks, Marcin -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists