linux-kernel - Re: [PATCH -mm] mm/oom_kill: change oom_kill_process() to bump ->mm_count rather than ->mm

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151006162654.GA9570@redhat.com>
Date:	Tue, 6 Oct 2015 18:26:54 +0200
From:	Oleg Nesterov <oleg@...hat.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
Cc:	David Rientjes <rientjes@...gle.com>,
	Kyle Walker <kwalker@...hat.com>,
	Michal Hocko <mhocko@...nel.org>,
	Stanislav Kozina <skozina@...hat.com>,
	Tetsuo Handa <penguin-kernel@...ove.SAKURA.ne.jp>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH -mm] mm/oom_kill: change oom_kill_process() to bump
	->mm_count rather than ->mm_users

On 10/05, Oleg Nesterov wrote:
>
> Self nack to the changelog ;)
>
> I still think the patch is fine, I'll resend it. But the changelog
> is wrong, in the case above access_process_vm() adds another reference
> to ->mm_users, so mmput() can never lead to mm_users == 0.

Please see v2 with updated changelog I am going to send. However, somehow
I forgot that "mm/oom_kill.c: fix potentially killing unrelated process"
still sits in -mm, so I guess it would be better to fold this change into
mmoom-fix-potentially-killing-unrelated-process.patch.

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/