lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:	Tue, 6 Oct 2015 11:21:41 -0700
From:	Andy Lutomirski <luto@...capital.net>
To:	Ingo Molnar <mingo@...nel.org>
Cc:	Andy Lutomirski <luto@...nel.org>, X86 ML <x86@...nel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	Brian Gerst <brgerst@...il.com>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH v2 09/36] x86/asm: Re-add manual CFI infrastructure

On Tue, Oct 6, 2015 at 1:23 AM, Ingo Molnar <mingo@...nel.org> wrote:
>
> * Andy Lutomirski <luto@...nel.org> wrote:
>
>> Commit 131484c8da97 ("x86/debug: Remove perpetually broken,
>> unmaintainable dwarf annotations") removed all the manual DWARF
>> annotations outside the vDSO.  It also removed the macros we used
>> for the manual annotations.
>>
>> Re-add the macros so that we can clean up the vDSO annotations.
>>
>> Signed-off-by: Andy Lutomirski <luto@...nel.org>
>> ---
>>  arch/x86/Makefile             |  10 ++-
>>  arch/x86/include/asm/dwarf2.h | 170 ++++++++++++++++++++++++++++++++++++++++++
>>  2 files changed, 178 insertions(+), 2 deletions(-)
>>  create mode 100644 arch/x86/include/asm/dwarf2.h
>
> Please don't add all this gunk back in!
>
> AFAICS the later patches use just a very small subset - add only the minimal
> subset absolutely needed.

OK, I'll strip out the push, movq, etc stuff for v3.  I'll leave all
of the CFI_XYZ macros, even the unused one, because that's only a
couple of lines of code and they all have very simple and obvious
meanings (or as simple as the underlying directives, anyway).

--Andy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Powered by blists - more mailing lists