linux-kernel - [PATCH] nfc: netlink: avoid NULL pointer dereference on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1444210399-3913-1-git-send-email-vincent.stehle@laposte.net>
Date:	Wed,  7 Oct 2015 11:33:19 +0200
From:	Vincent Stehlé <vincent.stehle@...oste.net>
To:	linux-wireless@...r.kernel.org
Cc:	netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
	Vincent Stehlé <vincent.stehle@...oste.net>,
	Thierry Escande <thierry.escande@...ux.intel.com>,
	Samuel Ortiz <sameo@...ux.intel.com>
Subject: [PATCH] nfc: netlink: avoid NULL pointer dereference on error

The function nfc_genl_llc_sdreq() can dereference the dev pointer while
it is NULL on its error path. Create a new error handling label to avoid
that.

This fixes the following coccinelle error:

  ./net/nfc/netlink.c:1175:21-24: ERROR: dev is NULL but dereferenced.

Signed-off-by: Vincent Stehlé <vincent.stehle@...oste.net>
Cc: Thierry Escande <thierry.escande@...ux.intel.com>
Cc: Samuel Ortiz <sameo@...ux.intel.com>
---
 net/nfc/netlink.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/net/nfc/netlink.c b/net/nfc/netlink.c
index 853172c..51c48f0 100644
--- a/net/nfc/netlink.c
+++ b/net/nfc/netlink.c
@@ -1111,7 +1111,7 @@ static int nfc_genl_llc_sdreq(struct sk_buff *skb, struct genl_info *info)
 	dev = nfc_get_device(idx);
 	if (!dev) {
 		rc = -ENODEV;
-		goto exit;
+		goto exit_nodev;
 	}
 
 	device_lock(&dev->dev);
@@ -1176,6 +1176,7 @@ exit:
 
 	nfc_put_device(dev);
 
+exit_nodev:
 	return rc;
 }
 
-- 
2.5.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/