linux-kernel - [PATCH v2 0/3] nvmem: make sysfs binary file permissions more flexible.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <1444215536-10783-1-git-send-email-srinivas.kandagatla@linaro.org>
Date:	Wed,  7 Oct 2015 11:58:56 +0100
From:	Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
To:	gregkh@...uxfoundation.org
Cc:	maxime.ripard@...e-electrons.com, linux-kernel@...r.kernel.org,
	andrew@...n.ch, wxt@...k-chips.com, stefan.wahren@...e.com,
	pantelis.antoniou@...sulko.com, maitysanchayan@...il.com,
	p.zabel@...gutronix.de, s.hauer@...gutronix.de,
	srinivas.kandagatla@...aro.org,
	linux-arm-kernel@...ts.infradead.org
Subject: [PATCH v2 0/3] nvmem: make sysfs binary file permissions more flexible.

Hi Greg, 

If its not too late for v4.4, can you please consider this patchset for v4.4.

Recent discussion raised by Andrew Lunn and others regarding default permission
set on the nvmem binary sysfs file resulted in this small fixup patchset.

By default nvmem core sets the readonly permission to everyone (S_IRUGO), this
is not desirable by many providers as they would not want everyone to view things
like passwords stored in the nvmem.

This patchset fixes this by making the default as root-only and then the
providers could supply with additional permissions if required. One of
the patch in this set also sets correct size for the binary file too,
so that the user would not even attempt to read past the size.

I have tested this on IFC6410 with qfprom.

Thanks,
srini

Changes since RFC (https://lkml.org/lkml/2015/8/11/319)
- Renamed perm to mode flag as suggested by Stefan Wahren

Srinivas Kandagatla (3):
  nvmem: core: make default user binary file root-access only
  nvmem: core: set the size for the nvmem binary file.
  nvmem: core: add sysfs file mode flag in nvmem_config

 drivers/nvmem/core.c           | 54 ++++++++++--------------------------------
 include/linux/nvmem-provider.h |  1 +
 2 files changed, 14 insertions(+), 41 deletions(-)

-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/