lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <5614FE88.4030909@ti.com>
Date: Wed, 7 Oct 2015 14:14:16 +0300
From: Tomi Valkeinen <tomi.valkeinen@...com>
To: Sudip Mukherjee <sudipm.mukherjee@...il.com>,
Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>
CC: <linux-kernel@...r.kernel.org>, <linux-fbdev@...r.kernel.org>
Subject: Re: [PATCH] video: of: fix memory leak
On 30/09/15 12:54, Sudip Mukherjee wrote:
> If of_parse_display_timing() fails we are printing an error message and
> jumping to the error path but we missed freeing "dt".
>
> Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> ---
> drivers/video/of_display_timing.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/video/of_display_timing.c b/drivers/video/of_display_timing.c
> index 32d8275..8a1076b 100644
> --- a/drivers/video/of_display_timing.c
> +++ b/drivers/video/of_display_timing.c
> @@ -210,6 +210,7 @@ struct display_timings *of_get_display_timings(struct device_node *np)
> */
> pr_err("%s: error in timing %d\n",
> of_node_full_name(np), disp->num_timings + 1);
> + kfree(dt);
> goto timingfail;
> }
Thanks, queued for 4.3 fixes.
Tomi
Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)
Powered by blists - more mailing lists