linux-kernel - Re: [PATCH] lockd: get rid of reference-counted NSM RPC clients

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Wed, 7 Oct 2015 19:28:21 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Andrey Ryabinin <aryabinin@...tuozzo.com>
Cc:	kbuild-all@...org,
	Trond Myklebust <trond.myklebust@...marydata.com>,
	Anna Schumaker <anna.schumaker@...app.com>,
	"J. Bruce Fields" <bfields@...ldses.org>,
	Jeff Layton <jlayton@...chiereds.net>,
	linux-nfs@...r.kernel.org, linux-kernel@...r.kernel.org,
	Stanislav Kinsbursky <skinsbursky@...tuozzo.com>,
	Andrey Ryabinin <aryabinin@...tuozzo.com>
Subject: Re: [PATCH] lockd: get rid of reference-counted NSM RPC clients

Hi Andrey,

[auto build test WARNING on next-20151007 -- if it's inappropriate base, please ignore]

config: mips-allyesconfig (attached as .config)
reproduce:
        wget https://git.kernel.org/cgit/linux/kernel/git/wfg/lkp-tests.git/plain/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # save the attached .config to linux build tree
        make.cross ARCH=mips 

All warnings (new ones prefixed by >>):

   In file included from include/linux/printk.h:6:0,
                    from include/linux/kernel.h:13,
                    from fs/lockd/mon.c:10:
   fs/lockd/mon.c: In function 'nsm_mon_unmon':
   include/linux/kern_levels.h:4:18: warning: format '%d' expects argument of type 'int', but argument 2 has type 'long int' [-Wformat=]
    #define KERN_SOH "\001"  /* ASCII Start Of Header */
                     ^
   include/linux/kern_levels.h:16:22: note: in expansion of macro 'KERN_SOH'
    #define KERN_DEFAULT KERN_SOH "d" /* the default kernel loglevel */
                         ^
>> include/linux/sunrpc/debug.h:33:11: note: in expansion of macro 'KERN_DEFAULT'
       printk(KERN_DEFAULT args); \
              ^
>> include/linux/sunrpc/debug.h:23:26: note: in expansion of macro 'dfprintk'
    #define dprintk(args...) dfprintk(FACILITY, ## args)
                             ^
>> fs/lockd/mon.c:111:3: note: in expansion of macro 'dprintk'
      dprintk("lockd: failed to create NSM upcall transport, "
      ^

vim +/dprintk +111 fs/lockd/mon.c

    95			.priv		= &nsm->sm_priv,
    96			.prog		= NLM_PROGRAM,
    97			.vers		= 3,
    98			.proc		= NLMPROC_NSM_NOTIFY,
    99			.mon_name	= nsm->sm_mon_name,
   100			.nodename	= host->nodename,
   101		};
   102		struct rpc_message msg = {
   103			.rpc_argp	= &args,
   104			.rpc_resp	= res,
   105		};
   106	
   107		memset(res, 0, sizeof(*res));
   108	
   109		clnt = nsm_create(host->net, host->nodename);
   110		if (IS_ERR(clnt)) {
 > 111			dprintk("lockd: failed to create NSM upcall transport, "
   112				"status=%d, net=%p\n", PTR_ERR(clnt), host->net);
   113			return PTR_ERR(clnt);
   114		}
   115	
   116		msg.rpc_proc = &clnt->cl_procinfo[proc];
   117		status = rpc_call_sync(clnt, &msg, RPC_TASK_SOFTCONN);
   118		if (status == -ECONNREFUSED) {
   119			dprintk("lockd:	NSM upcall RPC failed, status=%d, forcing rebind\n",

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (39683 bytes)