lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <7161690.NZs9VETTEZ@wuerfel> Date: Wed, 07 Oct 2015 14:37:35 +0200 From: Arnd Bergmann <arnd@...db.de> To: ygardi@...eaurora.org Cc: james.bottomley@...senpartnership.com, linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org, linux-arm-msm@...r.kernel.org, santoshsy@...il.com, linux-scsi-owner@...r.kernel.org, subhashj@...eaurora.org, gbroner@...eaurora.org, draviv@...eaurora.org, Noa Rubens <noag@...eaurora.org>, Raviv Shvili <rshvili@...eaurora.org>, Vinayak Holikatti <vinholikatti@...il.com>, "James E.J. Bottomley" <jbottomley@...n.com>, "open list:ABI/API" <linux-api@...r.kernel.org> Subject: Re: [PATCH v2] scsi: ufs: add ioctl interface for query request On Wednesday 07 October 2015 12:27:54 ygardi@...eaurora.org wrote: > > >> + > >> +/* > >> + * IOCTL opcode for ufs queries has the following opcode after > >> + * SCSI_IOCTL_GET_PCI > >> + */ > >> +#define UFS_IOCTL_QUERY 0x5388 > > > > Use _IOWR() to define that number with the correct argument length > > i'd rather leave it as is, to be compatible with the SCSI_IOCTL > opcodes that are defined in scsi_ioctl.h Do you mean you require this code to work on SunOS? ;-) If not, better use the normal conventions that Linux and BSD have for new ioctls. Note that the 0x53xx ioctl command numbers are also used by include/uapi/linux/cdrom.h, this one would be right in the middle of that. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists