linux-kernel - Re: [PATCH] misc: eeprom: at25: add Cypress FRAM functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <201510072046.t8mkoGKE%fengguang.wu@intel.com>
Date:	Wed, 7 Oct 2015 20:38:16 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Jiri Prchal <jiri.prchal@...ignal.cz>
Cc:	kbuild-all@...org, gregkh@...uxfoundation.org,
	srinivas.kandagatla@...aro.org, maxime.ripard@...e-electrons.com,
	rafael.j.wysocki@...el.com, mika.westerberg@...ux.intel.com,
	grant.likely@...aro.org, linux-kernel@...r.kernel.org,
	Jiri Prchal <jiri.prchal@...ignal.cz>
Subject: Re: [PATCH] misc: eeprom: at25: add Cypress FRAM functionality

Hi Jiri,

[auto build test WARNING on v4.3-rc4 -- if it's inappropriate base, please ignore]

reproduce:
        # apt-get install sparse
        make ARCH=x86_64 allmodconfig
        make C=1 CF=-D__CHECK_ENDIAN__


sparse warnings: (new ones prefixed by >>)

>> drivers/misc/eeprom/at25.c:401:51: sparse: incorrect type in argument 3 (different modifiers)
   drivers/misc/eeprom/at25.c:401:51:    expected char const **val
   drivers/misc/eeprom/at25.c:401:51:    got char **<noident>
   In file included from include/linux/printk.h:277:0,
                    from include/linux/kernel.h:13,
                    from drivers/misc/eeprom/at25.c:13:
   drivers/misc/eeprom/at25.c: In function 'fm25_id_read':
   drivers/misc/eeprom/at25.c:170:3: warning: format '%Zd' expects argument of type 'signed size_t', but argument 4 has type 'int' [-Wformat=]
      "read %Zd bytes of ID --> %d\n",
      ^
   include/linux/dynamic_debug.h:86:39: note: in definition of macro 'dynamic_dev_dbg'
      __dynamic_dev_dbg(&descriptor, dev, fmt, \
                                          ^
   drivers/misc/eeprom/at25.c:169:2: note: in expansion of macro 'dev_dbg'
     dev_dbg(&at25->spi->dev,
     ^
   drivers/misc/eeprom/at25.c: In function 'fm25_sernum_read':
   drivers/misc/eeprom/at25.c:200:3: warning: format '%Zd' expects argument of type 'signed size_t', but argument 4 has type 'int' [-Wformat=]
      "read %Zd bytes of serial number --> %d\n",
      ^
   include/linux/dynamic_debug.h:86:39: note: in definition of macro 'dynamic_dev_dbg'
      __dynamic_dev_dbg(&descriptor, dev, fmt, \
                                          ^
   drivers/misc/eeprom/at25.c:199:2: note: in expansion of macro 'dev_dbg'
     dev_dbg(&at25->spi->dev,
     ^
   drivers/misc/eeprom/at25.c: In function 'at25_fw_to_chip':
   drivers/misc/eeprom/at25.c:401:43: warning: passing argument 3 of 'device_property_read_string' from incompatible pointer type [-Wincompatible-pointer-types]
     device_property_read_string(dev, "name", &name);
                                              ^
   In file included from drivers/misc/eeprom/at25.c:22:0:
   include/linux/property.h:41:5: note: expected 'const char **' but argument is of type 'char **'
    int device_property_read_string(struct device *dev, const char *propname,
        ^

vim +401 drivers/misc/eeprom/at25.c

   385				  off_t offset, size_t count)
   386	{
   387		struct at25_data *at25 = container_of(mem, struct at25_data, mem);
   388	
   389		return at25_ee_write(at25, buf, offset, count);
   390	}
   391	
   392	/*-------------------------------------------------------------------------*/
   393	
   394	static int at25_fw_to_chip(struct device *dev, struct spi_eeprom *chip,
   395				   int is_fram)
   396	{
   397		u32 val;
   398		char *name;
   399	
   400		memset(chip, 0, sizeof(*chip));
 > 401		device_property_read_string(dev, "name", &name);
   402		strncpy(chip->name, name, sizeof(chip->name));
   403	
   404		if (is_fram) {
   405			if (device_property_present(dev, "read-only"))
   406				chip->flags |= EE_READONLY;
   407			return 0;
   408		}
   409	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/