lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <51655489.62UKkKA6xS@wuerfel> Date: Wed, 07 Oct 2015 15:31:07 +0200 From: Arnd Bergmann <arnd@...db.de> To: Florian Fainelli <f.fainelli@...il.com> Cc: Thierry Reding <thierry.reding@...il.com>, linux-kernel@...r.kernel.org, bcm-kernel-feedback-list@...adcom.com, devicetree@...r.kernel.org, linux-pwm@...r.kernel.org, ariel@...guardiasur.com.ar Subject: Re: [PATCH] pwm: fix Broadcom BCM7038 PWM driver On Tuesday 06 October 2015 17:51:30 Florian Fainelli wrote: > On 06/10/15 12:59, Arnd Bergmann wrote: > > The newly added pwm-brcmstb driver fails to build if CONFIG_PM_SLEEP > > is enabled: > > > > drivers/pwm/pwm-brcmstb.c: In function 'brcmstb_pwm_suspend': > > drivers/pwm/pwm-brcmstb.c:309:42: error: 'dev' undeclared (first use in this function) > > struct brcmstb_pwm *p = dev_get_drvdata(dev); > > > > This changes the name of the function argument to match its user. > > Thanks, maybe, to avoid similar issues in the future, we should start > removing the ifdef CONFIG_PM_SLEEP and instead annotate such functions > with __maybe_unused. I wonder if we could magically make that happen > with a coccinelle script that looks for SIMPLE_DEV_PM_OPS to know which > functions to annotate... humm. I think the best solution would be to replace SIMPLE_DEV_PM_OPS with a macro that creates an unused reference to the functions. That way, we could remove all the #ifdef CONFIG_PM_SLEEP from the kernel, but we'd still have to use coccinelle to replace all the current instances with the new macro. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists