linux-kernel - Re: [PATCH] ASoC: rt5645: fix build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151007140527.GK12635@sirena.org.uk>
Date:	Wed, 7 Oct 2015 15:05:27 +0100
From:	Mark Brown <broonie@...nel.org>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
Cc:	Bard Liao <bardliao@...ltek.com>,
	Oder Chiou <oder_chiou@...ltek.com>,
	Liam Girdwood <lgirdwood@...il.com>,
	Jaroslav Kysela <perex@...ex.cz>,
	Takashi Iwai <tiwai@...e.com>, linux-kernel@...r.kernel.org,
	alsa-devel@...a-project.org
Subject: Re: [PATCH] ASoC: rt5645: fix build warning

On Wed, Oct 07, 2015 at 05:52:12PM +0530, Sudip Mukherjee wrote:
> We were getting build warning about "Section mismatch".
> dmi_platform_intel_broadwell is being referenced from the probe function
> rt5645_i2c_probe(), but dmi_platform_intel_broadwell was marked with
> __initdata.
> 
> Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>

> -static struct dmi_system_id dmi_platform_intel_broadwell[] __initdata = {
> +static struct dmi_system_id dmi_platform_intel_broadwell[] = {

This doesn't seem like the obvious fix - why are we not annotating the
probe function suitably (or alternatively if we can't why does
__initdata still exist)?

Download attachment "signature.asc" of type "application/pgp-signature" (474 bytes)