lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20151007154303.GC24678@thunk.org> Date: Wed, 7 Oct 2015 11:43:03 -0400 From: Theodore Ts'o <tytso@....edu> To: Linus Torvalds <torvalds@...ux-foundation.org> Cc: Dave Hansen <dave.hansen@...el.com>, Andrew Morton <akpm@...ux-foundation.org>, "linux-ext4@...r.kernel.org" <linux-ext4@...r.kernel.org>, Linux Kernel Mailing List <linux-kernel@...r.kernel.org> Subject: Re: [REGRESSION] 998ef75ddb and aio-dio-invalidate-failure w/ data=journal On Wed, Oct 07, 2015 at 08:32:16AM +0100, Linus Torvalds wrote: > And none of *those* requirements change just because "copied" would be > zero. If you avoid zeroing the buffers and marking them dirty, nothing > will ever initialize them on disk, andn if the prefault then later > fails during retry, no later write will happen either. So now > eventually later, a read() can see stale data from disk. Shoot. You're right, we could end up allowing a stale data to be exposed. If we knew the caller of write_end() was guaranteed to retry, we could skip the jbd2_journal_stop() call and keep the handle open, which would prevent the transaction from closing. But if the write gets abandoned, then the transaction would never close, and things would grind to a halt. > I do think this is an ext4 bug, and you'll need to do something *like* > that patch. Maybe Dave's patch is good as-is. It's the "I think you > need to do more" that I worry about. Not at -rc4 time. Not with a core > filesystem like ext4. Let's not hurry this too much. Agreed, I know what to do, and and the change is not something I'd want to get in -rc4. I'll target a fix for the next merge window. - Ted -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists