linux-kernel - Re: [PATCH] perf tools: get version from uname(2), not /proc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151007171107.GA8650@whiteoak.sf.office.twttr.net>
Date:	Wed, 7 Oct 2015 10:11:08 -0700
From:	Matt Mullins <mmullins@...pensource.com>
To:	Adrian Hunter <adrian.hunter@...el.com>
Cc:	Jiri Olsa <jolsa@...hat.com>, acme@...nel.org,
	Vinson Lee <vlee@...pensource.com>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>,
	Ingo Molnar <mingo@...hat.com>,
	Namhyung Kim <namhyung@...nel.org>,
	Kan Liang <kan.liang@...el.com>,
	Andi Kleen <ak@...ux.intel.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] perf tools: get version from uname(2), not /proc

On Wed, Oct 07, 2015 at 11:19:17AM +0300, Adrian Hunter wrote:
> On 07/10/15 11:18, Jiri Olsa wrote:
> > On Tue, Oct 06, 2015 at 03:53:14PM -0700, Matt Mullins wrote:
> >> Tools in kmod (e.g. modprobe) compose the module path from the release
> >> from uname(2).  Because we use the UNAME26 personality, we need perf to
> >> find modules located at the same path as the system tools.
> > 
> > I guess it's easy to google this up, but could you
> > please state in the changelog what's the difference
> > between the current version and the UNAME26 one?
> > 
> > Also state (and check) this change wouldn't affect other
> > parts of the code that use this version (if there's any).

This is the only caller of get_kernel_version.

> Isn't the machine root dir for guests? uname() won't work for them.

Aye, this would break --guestmount.  Would it make sense to use uname()
iff root_dir is the empty string, or is that too much special-casing for
good taste?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/