lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <alpine.OSX.2.00.1510071441460.1714@dns1.prod.a4.vary.redhat.com> Date: Wed, 7 Oct 2015 14:49:22 -0400 From: Chad Dupuis <chad.dupuis@...gic.com> To: Maurizio Lombardi <mlombard@...hat.com> CC: Arnd Bergmann <arnd@...db.de>, <linux-scsi@...r.kernel.org>, <QLogic-Storage-Upstream@...gic.com>, "James E.J. Bottomley" <JBottomley@...n.com>, <linux-kernel@...r.kernel.org>, <linux-arm-kernel@...ts.infradead.org>, Joe Carnuccio <joe.carnuccio@...gic.com>, Yuval Mintz <Yuval.Mintz@...gic.com>, "David S. Miller" <davem@...emloft.net>, <netdev@...r.kernel.org> Subject: Re: [PATCH] bnx2fc: reduce stack usage in __bnx2fc_enable On Wed, 7 Oct 2015, Maurizio Lombardi wrote: > Hi, > > On 10/07/2015 03:11 PM, Arnd Bergmann wrote: >> - memset(&npiv_tbl, 0, sizeof(npiv_tbl)); >> - if (hba->cnic->get_fc_npiv_tbl(hba->cnic, &npiv_tbl)) >> + npiv_tbl = kzalloc(sizeof(struct cnic_fc_npiv_tbl), GFP_KERNEL); >> + if (!npiv_tbl) >> goto done; >> > > If kzalloc() fails perhaps the function should return -ENOMEM, not zero. > The enablement of the fcoe interface can still proceed if this particular allocation fails so returning 0 would be appropriate here. This patch looks good to me. > > Regards, > Maurizio Lombardi > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists