linux-kernel - Re: [PATCH] gpio: make GPIO_OMAP bool instead of tristate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <56157024.1070905@ti.com>
Date:	Wed, 7 Oct 2015 14:19:00 -0500
From:	Grygorii Strashko <grygorii.strashko@...com>
To:	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Arnd Bergmann <arnd@...db.de>
CC:	Linus Walleij <linus.walleij@...aro.org>,
	Alexandre Courbot <gnurou@...il.com>,
	<linux-kernel@...r.kernel.org>, <linux-gpio@...r.kernel.org>,
	Tony Lindgren <tony@...mide.com>,
	Austin Schuh <austin@...oton-tech.com>,
	Santosh Shilimkar <ssantosh@...nel.org>
Subject: Re: [PATCH] gpio: make GPIO_OMAP bool instead of tristate

On 10/07/2015 02:27 AM, Sudip Mukherjee wrote:
> On Tue, Oct 06, 2015 at 03:45:07PM -0500, Grygorii Strashko wrote:
>> On 10/06/2015 07:01 AM, Sudip Mukherjee wrote:
>>> While building arm allmodconfig the build fails with the error:
>>> ERROR: "handle_bad_irq" [drivers/gpio/gpio-omap.ko] undefined!
>>>
>>> The build breaks as handle_bad_irq is not exported for module use.
>>
>> Not sure if this is right thing to do. We really want it to be a module if needed.
>>
>> The handle_bad_irq() was used in this driver to catch the case when Omap
>> GPIO IRQ is enabled before calling .irq_set_type()
>>
>> I think there are few option:
>> - export handle_bad_irq()
>> - pass NULL in gpiochip_irqchip_add() instead of handle_bad_irq()
>> - use handle_simple_irq()
>> - revert this change
>>
>> Thought second one should work.
>
> I think that should be ok. If you want me to test the patch in my setup
> to verify that it fixes the build failure please let me know.
>
> But going through the old thread it looked like plan was on to
> export handle_bad_irq() atleast thats what looks like from Linus's
> (Linus Walleij) reply in https://lkml.org/lkml/2014/2/25/119

There is patch from Arnd which implements option one.
https://lkml.org/lkml/2015/10/6/836

-- 
regards,
-grygorii
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/