linux-kernel - Re: [PATCH next] staging: wilc1000: avoid NULL pointer dereference on error

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Wed, 7 Oct 2015 09:23:58 +0300
From:	Dan Carpenter <dan.carpenter@...cle.com>
To:	Vincent Stehlé <vincent.stehle@...oste.net>
Cc:	devel@...verdev.osuosl.org, Rachel Kim <rachel.kim@...el.com>,
	Dean Lee <dean.lee@...el.com>,
	Chris Park <chris.park@...el.com>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	linux-wireless@...r.kernel.org, Johnny Kim <johnny.kim@...el.com>,
	linux-kernel@...r.kernel.org,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Subject: Re: [PATCH next] staging: wilc1000: avoid NULL pointer dereference
 on error

On Wed, Oct 07, 2015 at 07:08:25AM +0200, Vincent Stehlé wrote:
>  drivers/staging/wilc1000/host_interface.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/staging/wilc1000/host_interface.c b/drivers/staging/wilc1000/host_interface.c
> index 2cf82b2..2fe3023 100644
> --- a/drivers/staging/wilc1000/host_interface.c
> +++ b/drivers/staging/wilc1000/host_interface.c
> @@ -6017,7 +6017,7 @@ s32 host_int_init(tstrWILC_WFIDrv **phWFIDrv)
>  	pstrWFIDrv  = kzalloc(sizeof(tstrWILC_WFIDrv), GFP_KERNEL);
>  	if (!pstrWFIDrv) {
>  		result = -ENOMEM;
> -		goto _fail_timer_2;
> +		goto _fail_;

Fair enough.  I would have prefered a direct return, but his also works.

The error handling in this function is still very bad and nonsensical.
You have fixed the first goto but all the others are buggy as well.

if add_handler_in_list() fails we should "goto free_pstrWFIDrv" (except
the label name should have Hungarian notation or CamelCase).  Instead of
freeing the current code unlocks a lock which is not initialiazed and
frees some timers which are also not initialized.

TODO: wilc1000: fix error handling in host_int_init()

regards,
dan carpenter


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/