lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-ID: <20151008094444.10d9cc68@canb.auug.org.au> Date: Thu, 8 Oct 2015 09:44:44 +1100 From: Stephen Rothwell <sfr@...b.auug.org.au> To: Linus Torvalds <torvalds@...ux-foundation.org> Cc: linux-next@...r.kernel.org, linux-kernel@...r.kernel.org, Chris Metcalf <cmetcalf@...hip.com>, <linuxppc-dev@...ts.ozlabs.org> Subject: linux-next: build failure after merge of Linus' tree Hi Linus, After merging Linus' tree, today's linux-next build (powerpc ppc64_defconfig) failed like this: lib/string.c: In function 'strscpy': lib/string.c:209:4: error: implicit declaration of function 'zero_bytemask' [-Werror=implicit-function-declaration] *(unsigned long *)(dest+res) = c & zero_bytemask(data); ^ Caused by commit 30035e45753b ("string: provide strscpy()") but only exposed by commit 19c22f3a29fa ("word-at-a-time.h: fix some Kbuild files") BIG_ENDIAN powerpc doesn't have a definition for this function ... Isn't this why we have linux-next ... to find this stuff early? :-( Oh, well, I have applied the following (that just copies zero_bytemask from asm-generic. I have done no testing beyond compiling. From: Stephen Rothwell <sfr@...b.auug.org.au> Date: Thu, 8 Oct 2015 09:29:26 +1100 Subject: [PATCH] word-at-a-time.h: powerpc: implement define zero_bytemask Signed-off-by: Stephen Rothwell <sfr@...b.auug.org.au> --- arch/powerpc/include/asm/word-at-a-time.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/arch/powerpc/include/asm/word-at-a-time.h b/arch/powerpc/include/asm/word-at-a-time.h index 5b3a903adae6..4f9b6b93c18f 100644 --- a/arch/powerpc/include/asm/word-at-a-time.h +++ b/arch/powerpc/include/asm/word-at-a-time.h @@ -40,6 +40,8 @@ static inline bool has_zero(unsigned long val, unsigned long *data, const struct return (val + c->high_bits) & ~rhs; } +#define zero_bytemask(mask) (~1ul << __fls(mask)) + #else #ifdef CONFIG_64BIT -- 2.5.1 -- Cheers, Stephen Rothwell sfr@...b.auug.org.au -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists