linux-kernel - Re: [PATCH v2] mlxsw: fix warnings for big-endian 32-bit dma_addr

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151007070036.GE2152@nanopsycho.orion>
Date:	Wed, 7 Oct 2015 09:00:37 +0200
From:	Jiri Pirko <jiri@...nulli.us>
To:	Arnd Bergmann <arnd@...db.de>
Cc:	Joe Perches <joe@...ches.com>, netdev@...r.kernel.org,
	davem@...emloft.net, Jiri Pirko <jiri@...lanox.com>,
	Ido Schimmel <idosch@...lanox.com>,
	linux-kernel@...r.kernel.org, Elad Raz <eladr@...lanox.com>,
	Scott Feldman <sfeldma@...il.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v2] mlxsw: fix warnings for big-endian 32-bit dma_addr_t

Wed, Oct 07, 2015 at 08:58:34AM CEST, arnd@...db.de wrote:
>The recently added mlxsw driver produces warnings in ARM
>allmodconfig:
>
>drivers/net/ethernet/mellanox/mlxsw/pci.c: In function 'mlxsw_pci_cmd_exec':
>drivers/net/ethernet/mellanox/mlxsw/pci.c:1585:59: warning: right shift count >= width of type [-Wshift-count-overflow]
>linux/byteorder/big_endian.h:38:51: note: in definition of macro '__cpu_to_be32'
>drivers/net/ethernet/mellanox/mlxsw/pci.c:76:2: note: in expansion of macro 'iowrite32be'
>
>This uses upper_32_bits() to extract the bits while avoiding that warning.
>
>Signed-off-by: Arnd Bergmann <arnd@...db.de>
>Acked-by: Jiri Pirko <jiri@...lanox.com>
>Fixes: eda6500a987a "mlxsw: Add PCI bus implementation"
>---
>I've kept Jiri's Ack despite having in effect a completely different
>patch here, as the effect and the changelog is the same for practical purposes.
>Hope that's ok.

It's ok, thanks.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/