linux-kernel - Re: [PATCH v3 2/3] uio_pci_generic: add MSI/MSI-X support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151008084823.GC19331@redhat.com>
Date:	Thu, 8 Oct 2015 11:48:23 +0300
From:	"Michael S. Tsirkin" <mst@...hat.com>
To:	Vlad Zolotarov <vladz@...udius-systems.com>
Cc:	Alex Williamson <alex.williamson@...hat.com>,
	Avi Kivity <avi@...lladb.com>,
	Greg KH <gregkh@...uxfoundation.org>,
	linux-kernel@...r.kernel.org, hjk@...sjkoch.de, corbet@....net,
	bruce.richardson@...el.com, avi@...udius-systems.com,
	gleb@...udius-systems.com, stephen@...workplumber.org,
	alexander.duyck@...il.com
Subject: Re: [PATCH v3 2/3] uio_pci_generic: add MSI/MSI-X support

On Wed, Oct 07, 2015 at 10:55:30AM +0300, Vlad Zolotarov wrote:
>  * not safe - UIO

That's wrong. UIO (in particular uio_pci_generic) can be used
safely in many ways, for example with any device not doing DMA.  I
wouldn't put it upstream otherwise.

Make your driver work in such a way that it can be used safely,
and it can be merged.

But when you try to do this, you will find out just why VFIO/PCI is
1000s of LOC while your patch is only 500.

-- 
MST
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/