linux-kernel - Re: [PATCH] serial: atmel: fix compiler warning on address cast

Open Source and information security mailing list archives

Message-ID: <20151008090148.GE3485@piout.net>
Date:	Thu, 8 Oct 2015 11:01:48 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Andre Przywara <andre.przywara@....com>
Cc:	Nicolas Ferre <nicolas.ferre@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Uwe Kleine-König 
	<u.kleine-koenig@...gutronix.de>, linux-kernel@...r.kernel.org,
	linux-serial@...r.kernel.org, Jiri Slaby <jslaby@...e.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] serial: atmel: fix compiler warning on address cast

On 05/10/2015 at 18:00:52 +0100, Andre Przywara wrote :
> Turning on KVM and LPAE support on top of a multi_v7_defconfig will
> produce a compiler warning in the Atmel serial driver:
> drivers/tty/serial/atmel_serial.c: In function 'atmel_verify_port':
> drivers/tty/serial/atmel_serial.c:2299:6: warning: cast to pointer from integer of different size [-Wint-to-pointer-cast]
>   if ((void *)port->mapbase != ser->iomem_base)
>       ^
> 
> Fix that by using the cast on the right hand side instead, as similar
> code already does in other drivers.
> 
> Signed-off-by: Andre Przywara <andre.przywara@....com>
Acked-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>

> ---
>  drivers/tty/serial/atmel_serial.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/atmel_serial.c b/drivers/tty/serial/atmel_serial.c
> index cd30a45..28039ce 100644
> --- a/drivers/tty/serial/atmel_serial.c
> +++ b/drivers/tty/serial/atmel_serial.c
> @@ -2296,7 +2296,7 @@ static int atmel_verify_port(struct uart_port *port, struct serial_struct *ser)
>  		ret = -EINVAL;
>  	if (port->uartclk / 16 != ser->baud_base)
>  		ret = -EINVAL;
> -	if ((void *)port->mapbase != ser->iomem_base)
> +	if (port->mapbase != (unsigned long)ser->iomem_base)
>  		ret = -EINVAL;
>  	if (port->iobase != ser->port)
>  		ret = -EINVAL;
> -- 
> 2.5.1
> 
> 
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@...ts.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives