linux-kernel - Re: [PATCH] radeonfb: Deinline large functions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 8 Oct 2015 12:26:08 +0300
From:	Tomi Valkeinen <tomi.valkeinen@...com>
To:	Denys Vlasenko <dvlasenk@...hat.com>,
	Benjamin Herrenschmidt <benh@...nel.crashing.org>
CC:	Jean-Christophe Plagniol-Villard <plagnioj@...osoft.com>,
	Richard Purdie <rpurdie@...ys.net>,
	Chris Wilson <chris@...is-wilson.co.uk>,
	David Airlie <airlied@...ux.ie>,
	Alex Deucher <alexdeucher@...il.com>,
	Ben Skeggs <bskeggs@...hat.com>,
	Zhang Rui <rui.zhang@...el.com>, Len Brown <lenb@...nel.org>,
	Jesse Barnes <jbarnes@...tuousgeek.org>,
	Dave Airlie <airlied@...hat.com>,
	<linux-kernel@...r.kernel.org>, <linux-fbdev@...r.kernel.org>
Subject: Re: [PATCH] radeonfb: Deinline large functions



On 23/09/15 20:57, Denys Vlasenko wrote:
> With this .config: http://busybox.net/~vda/kernel_config,
> after uninlining these functions have sizes and callsite counts
> as follows:
> 
> __OUTPLLP: 61 bytes, 12 callsites
> __INPLL:   79 bytes, 150 callsites
> __OUTPLL:  82 bytes, 138 callsites
> _OUTREGP: 101 bytes, 8 callsites
> _radeon_msleep:      66 bytes, 18 callsites
> _radeon_fifo_wait:   83 bytes, 24 callsites
> _radeon_engine_idle: 92 bytes, 10 callsites
> radeon_engine_flush: 105 bytes, 2 callsites
> radeon_pll_errata_after_index_slow: 31 bytes, 11 callsites
> radeon_pll_errata_after_data_slow:  91 bytes, 9 callsites
> 
> radeon_pll_errata_after_FOO functions are split into two parts:
> the inlined part which checks corresponding rinfo->errata bit,
> and out-of-line part which performs workaround magic per se.
> 
> Reduction in code size is about 49,500 bytes:
> 
>     text     data      bss       dec     hex filename
> 85789648 22294616 20627456 128711720 7abfc28 vmlinux.before
> 85740176 22294680 20627456 128662312 7ab3b28 vmlinux

Thanks, applying for 4.4.

 Tomi


Download attachment "signature.asc" of type "application/pgp-signature" (820 bytes)