lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 08 Oct 2015 04:42:53 -0700 (PDT) From: David Miller <davem@...emloft.net> To: arnd@...db.de Cc: netdev@...r.kernel.org, fw@...len.de, pablo@...filter.org, ebiederm@...ssion.com, linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH] bridge/netfilter: avoid unused label warning From: Arnd Bergmann <arnd@...db.de> Date: Tue, 06 Oct 2015 21:22:12 +0200 > With the ARM mini2440_defconfig, the bridge netfilter code gets > built with both CONFIG_NF_DEFRAG_IPV4 and CONFIG_NF_DEFRAG_IPV6 > disabled, which leads to a harmless gcc warning: > > net/bridge/br_netfilter_hooks.c: In function 'br_nf_dev_queue_xmit': > net/bridge/br_netfilter_hooks.c:792:2: warning: label 'drop' defined but not used [-Wunused-label] > > This gets rid of the warning by cleaning up the code to avoid > the respective #ifdefs causing this problem, and replacing them > with if(IS_ENABLED()) checks. I have verified that the resulting > object code is unchanged, and an additional advantage is that > we now get compile coverage of the unused functions in more > configurations. > > Signed-off-by: Arnd Bergmann <arnd@...db.de> > Fixes: dd302b59bde0 ("netfilter: bridge: don't leak skb in error paths") This commit is in v4.2-rc3 and later, but this patch only applies to net-next as far as I can tell. Wouldn't it be better to base this on 'net', or even better Pablo's netfilter fixes tree, and while you are at it submit it properly to netfilter-devel with Pablo CC:'d as well? Thanks. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists