linux-kernel - RE: [PATCH 0/9] drivers:mtd:UBI: add bakvol module for MLC NAND paired page issue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <A765B125120D1346A63912DDE6D8B6310BF4D8ED@NTXXIAMBX02.xacn.micron.com>
Date:	Thu, 8 Oct 2015 00:49:10 +0000
From:	Bean Huo 霍斌斌 (beanhuo) 
	<beanhuo@...ron.com>
To:	Boris Brezillon <boris.brezillon@...e-electrons.com>
CC:	Richard Weinberger <richard@....at>,
	"dedekind1@...il.com" <dedekind1@...il.com>,
	"adrian.hunter@...el.com" <adrian.hunter@...el.com>,
	"computersforpeace@...il.com" <computersforpeace@...il.com>,
	"baruch@...s.co.il" <baruch@...s.co.il>,
	"asierra@...-inc.com" <asierra@...-inc.com>,
	"guz.fnst@...fujitsu.com" <guz.fnst@...fujitsu.com>,
	"gsi@...x.de" <gsi@...x.de>, David Woodhouse <dwmw2@...radead.org>,
	"linux-mtd@...ts.infradead.org" <linux-mtd@...ts.infradead.org>,
	Andrea Scian <rnd4@...e-tech.it>,
	Karl Zhang 张双锣 (karlzhang) 
	<karlzhang@...ron.com>,
	Iwo Mergler <Iwo.Mergler@...commwireless.com>,
	"Jeff Lauruhn (jlauruhn)" <jlauruhn@...ron.com>,
	Stefan Roese <sr@...x.de>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: RE: [PATCH 0/9] drivers:mtd:UBI: add bakvol module for MLC NAND
 paired page issue

> > > As stated before, using OOB in UBI is not going to happen unless
> > > proven that there is absolutely no other way to solve the paired pages
> problem.
> > >
> > > Nacked-by: Richard Weinberger <richard@....at>
> > >
> > > Sorry,
> > > //Richard
> >
> > Hi, Richard
> > Thanks for your concern. I am a new patch submitter.
> > Can you tell me Nacked-by means?
> >
> > By the way, Do you review my patches series ? I don't backup duplicated
> >data in OOB .
> 
> That's not what Richard said, he just pointed that you were using the OOB
> area, and you're actually using it to store the information about which page
> you're backuping.
> 
> > Can you specify which sector codes ? so that I can explain it in detail.
> 
> And as answered by Richard, check_original_data() and
> mtd_write_dual_plane_oob() are filling the OOB buf with the original page
> offset, so you're definitely using the OOB area to store metadata.

Yes ,currently I only use 4 bytes OOB area to store backup page address.

> --
> Boris Brezillon, Free Electrons
> Embedded Linux and Kernel engineering
> http://free-electrons.com