linux-kernel - Re: [PATCH 09/17] fs/hpfs: remove unnecessary new_valid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151008122201.GA3711@bbox>
Date:	Thu, 8 Oct 2015 20:22:01 +0800
From:	Yaowei Bai <bywxiaobai@....com>
To:	Mikulas Patocka <mikulas@...bright.com>
Cc:	viro@...iv.linux.org.uk, linux-fsdevel@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 09/17] fs/hpfs: remove unnecessary new_valid_dev check

On Thu, Oct 01, 2015 at 10:49:41PM +0200, Mikulas Patocka wrote:
> 
> 
> On Wed, 30 Sep 2015, Yaowei Bai wrote:
> 
> > On Tue, Sep 29, 2015 at 05:03:24PM +0200, Mikulas Patocka wrote:
> > > Hi
> > > 
> > > I suppose that you should remove the function new_valid_dev at all.
> > 
> > Yes, i thought about that, but actually there's still a user of
> > new_valid_dev in fs/stat.c:
> > 
> > 	#define valid_dev(x)  choose_32_64(old_valid_dev,new_valid_dev)(x)
> > 
> > so i just left new_valid_dev untouched and removed other users in fs first.
> 
> So, remove that too - change it to choose_32_64(old_valid_dev(x),true)
> 
> If you remove most calls for the function new_valid_dev, the function is 
> meaningless and shouldn't be present in the source code.

Sorry for delay reply. OK, i will follow your advice and send another patch to
remove it once this patchset's taken by vfs or mm tree. Thanks for reviewing.

Yaowei

> 
> Mikulas

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/