linux-kernel - [PATCH RESEND 3/3] drm/amdgpu: fix memory leak

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1444312681-10149-3-git-send-email-sudipm.mukherjee@gmail.com>
Date:	Thu,  8 Oct 2015 19:28:01 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	David Airlie <airlied@...ux.ie>,
	Daniel Vetter <daniel.vetter@...ll.ch>
Cc:	linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
	Sudip Mukherjee <sudipm.mukherjee@...il.com>,
	Christian König <christian.koenig@....com>,
	Jammy Zhou <Jammy.Zhou@....com>,
	Chunming Zhou <david1.zhou@....com>,
	Alex Deucher <alexander.deucher@....com>,
	"monk.liu" <monk.liu@....com>
Subject: [PATCH RESEND 3/3] drm/amdgpu: fix memory leak

If amdgpu_ib_get() fails we returned the error code but we missed
freeing ib.

Cc: "Christian König" <christian.koenig@....com>
Cc: Jammy Zhou <Jammy.Zhou@....com>
Cc: Chunming Zhou <david1.zhou@....com>
Cc: Alex Deucher <alexander.deucher@....com>
Cc: "monk.liu" <monk.liu@....com>
Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
---

Sent on 18/09/2015 

 drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
index 1e14531..53d551f 100644
--- a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
+++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c
@@ -455,8 +455,10 @@ int amdgpu_vm_update_page_directory(struct amdgpu_device *adev,
 		return -ENOMEM;
 
 	r = amdgpu_ib_get(ring, NULL, ndw * 4, ib);
-	if (r)
+	if (r) {
+		kfree(ib);
 		return r;
+	}
 	ib->length_dw = 0;
 
 	/* walk over the address space and update the page directory */
-- 
1.9.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/