linux-kernel - Re: [PATCH v3] scsi: ufs: add ioctl interface for query request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5970981.84uI3QIcdF@wuerfel>
Date:	Thu, 08 Oct 2015 16:03:08 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Yaniv Gardi <ygardi@...eaurora.org>
Cc:	James.Bottomley@...senpartnership.com,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, santoshsy@...il.com,
	linux-scsi-owner@...r.kernel.org, subhashj@...eaurora.org,
	gbroner@...eaurora.org, draviv@...eaurora.org,
	Noa Rubens <noag@...eaurora.org>,
	Raviv Shvili <rshvili@...eaurora.org>,
	Vinayak Holikatti <vinholikatti@...il.com>,
	"James E.J. Bottomley" <JBottomley@...n.com>,
	"open list:ABI/API" <linux-api@...r.kernel.org>
Subject: Re: [PATCH v3] scsi: ufs: add ioctl interface for query request

On Thursday 08 October 2015 14:09:24 Yaniv Gardi wrote:
> This patch exposes the ioctl interface for UFS driver via SCSI device
> ioctl interface. As of now UFS driver would provide the ioctl for query
> interface to connected UFS device.
> 
> Signed-off-by: Dolev Raviv <draviv@...eaurora.org>
> Signed-off-by: Noa Rubens <noag@...eaurora.org>
> Signed-off-by: Raviv Shvili <rshvili@...eaurora.org>
> Signed-off-by: Gilad Broner <gbroner@...eaurora.org>
> Signed-off-by: Yaniv Gardi <ygardi@...eaurora.org>

Thanks for the changes, looks much better already


> @@ -5106,6 +5308,10 @@ static struct scsi_host_template ufshcd_driver_template = {
>  	.eh_device_reset_handler = ufshcd_eh_device_reset_handler,
>  	.eh_host_reset_handler   = ufshcd_eh_host_reset_handler,
>  	.eh_timed_out		= ufshcd_eh_timed_out,
> +	.ioctl			= ufshcd_ioctl,
> +#ifdef CONFIG_COMPAT
> +	.compat_ioctl		= ufshcd_ioctl,
> +#endif
>  	.this_id		= -1,
>  	.sg_tablesize		= SG_ALL,
>  	.cmd_per_lun		= UFSHCD_CMD_PER_LUN,

no need for the #ifdef here.

> diff --git a/include/scsi/scsi.h b/include/scsi/scsi.h
> index e0a3398..fada160 100644
> --- a/include/scsi/scsi.h
> +++ b/include/scsi/scsi.h
> @@ -284,6 +284,7 @@ static inline int scsi_is_wlun(u64 lun)
>   * Here are some scsi specific ioctl commands which are sometimes useful.
>   *
>   * Note that include/linux/cdrom.h also defines IOCTL 0x5300 - 0x5395
> + * include/uapi/scsi/ufs/ioctl.h defines 0x5388
>   */
>  

The comment is now wrong.


Hmm, the buffer now is not aligned to four bytes, which will make copying it
a bit slower. If that can be a concern, adding a padding byte would help.

	Arnd

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/