linux-kernel - Re: [PATCH 13/44] kdbus: Use list_next_entry() in kdbus_queue_entry

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 8 Oct 2015 16:09:46 +0200
From:	David Herrmann <dh.herrmann@...il.com>
To:	Sergei Zviagintsev <sergei@...v.net>
Cc:	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Daniel Mack <daniel@...que.org>,
	David Herrmann <dh.herrmann@...glemail.com>,
	Djalal Harouni <tixxdz@...ndz.org>,
	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 13/44] kdbus: Use list_next_entry() in kdbus_queue_entry_unlink()

Hi

On Thu, Oct 8, 2015 at 1:31 PM, Sergei Zviagintsev <sergei@...v.net> wrote:
> Use list_next_entry() instead of list_first_entry().

This commit-message is completely useless. This is not a cosmetic
change, so please justify your changes. Sure, in this case both
list_next_entry() and list_first_entry() perform the same operation,
but you should really describe such changes in the commit message to
allow reviewers to understand the intent of your change.

Anyway, patch looks good, thanks!
David

> Signed-off-by: Sergei Zviagintsev <sergei@...v.net>
> ---
>  ipc/kdbus/queue.c | 3 +--
>  1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/ipc/kdbus/queue.c b/ipc/kdbus/queue.c
> index f9c44d7bae6d..90e8d16f5967 100644
> --- a/ipc/kdbus/queue.c
> +++ b/ipc/kdbus/queue.c
> @@ -157,8 +157,7 @@ static void kdbus_queue_entry_unlink(struct kdbus_queue_entry *entry)
>                  * the list. Update cached highest-priority entry, store the
>                  * new one as the tree node.
>                  */
> -               q = list_first_entry(&entry->prio_entry,
> -                                    struct kdbus_queue_entry, prio_entry);
> +               q = list_next_entry(entry, prio_entry);
>                 list_del(&entry->prio_entry);
>
>                 if (queue->msg_prio_highest == &entry->prio_node)
> --
> 1.8.3.1
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/