linux-kernel - Re: [PATCH] PCC: fix dereference of ERR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 8 Oct 2015 19:47:59 +0530
From:	Sudip Mukherjee <sudipm.mukherjee@...il.com>
To:	Jassi Brar <jassisinghbrar@...il.com>
Cc:	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] PCC: fix dereference of ERR_PTR

On Wed, Sep 16, 2015 at 07:34:24PM +0530, Sudip Mukherjee wrote:
> get_pcc_channel() does not return NULL on error it returns the error code
> in ERR_PTR, but we have been checking it for NULL.
> 
> Signed-off-by: Sudip Mukherjee <sudip@...torindia.org>
> ---
A gentle ping.

regards
sudip

>  drivers/mailbox/pcc.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c
> index 68885a8..45d85ae 100644
> --- a/drivers/mailbox/pcc.c
> +++ b/drivers/mailbox/pcc.c
> @@ -122,7 +122,7 @@ struct mbox_chan *pcc_mbox_request_channel(struct mbox_client *cl,
>  	 */
>  	chan = get_pcc_channel(subspace_id);
>  
> -	if (!chan || chan->cl) {
> +	if (IS_ERR(chan) || chan->cl) {
>  		dev_err(dev, "Channel not found for idx: %d\n", subspace_id);
>  		return ERR_PTR(-EBUSY);
>  	}
> -- 
> 1.9.1
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/