linux-kernel - Re: [PATCH v2] ARM: cns3xxx: pci: avoid potential stack overflow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Thu, 08 Oct 2015 16:38:31 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Krzysztof Hałasa <khalasa@...p.pl>
Cc:	linux-arm-kernel@...ts.infradead.org, linux-kernel@...r.kernel.org,
	linux-pci@...r.kernel.org, Bjorn Helgaas <bhelgaas@...gle.com>
Subject: Re: [PATCH v2] ARM: cns3xxx: pci: avoid potential stack overflow

On Thursday 08 October 2015 12:03:18 Krzysztof Hałasa wrote:
> Hi,
> 
> Arnd Bergmann <arnd@...db.de> writes:
> 
> > With those two changes in place, we no longer need the fake
> > pci_sys_data/pci_bus structures for faking config space writes,
> > and the stack usage goes down as well.
> 
> >  arch/arm/mach-cns3xxx/pcie.c | 71 +++++++++++++++++++++++++++++----------------------------------------
> 
> I'm ATM unable to test this change, but will do that at some point.
> Meanwhile, I guess there is nothing I can say against this patch.
> Thanks.
> 
> Acked-by: Krzysztof Hałasa <khalasa@...p.pl>
> 

Thanks! I've queued it up in next/fixes-non-critical for linux-4.4
now, if you find something wrong later, we can revert or fix up.

There is no urgency for this one, especially since you still want to
test it, so no reason to put it in 4.3.

This was the last pre-2015 build warning for the ARM defconfigs
and allmodconfig, all remaining warnings are regressions or new
code, and I've submitted patches for those. Let's see if we can
get to a warning-free kernel build in 4.4.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/