lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Thu, 8 Oct 2015 22:17:01 +0530 From: Alim Akhtar <alim.akhtar@...il.com> To: Krzysztof Kozlowski <k.kozlowski@...sung.com> Cc: Lukasz Majewski <l.majewski@...sung.com>, Zhang Rui <rui.zhang@...el.com>, Eduardo Valentin <edubezval@...il.com>, Kukjin Kim <kgene@...nel.org>, linux-pm@...r.kernel.org, "linux-samsung-soc@...r.kernel.org" <linux-samsung-soc@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>, "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org> Subject: Re: [PATCH 5/5] thermal: exynos: Directly return 0 instead of using local ret variable Hello, On Thu, Oct 8, 2015 at 11:04 AM, Krzysztof Kozlowski <k.kozlowski@...sung.com> wrote: > The 'ret' variable in exynos5440_tmu_initialize() is initialized to 0 > and returned as is. Replace it with direct return statement. This also > fixes coccinelle warning: > drivers/thermal/samsung/exynos_tmu.c:611:5-8: Unneeded variable: "ret". Return "0" on line 654 > > Signed-off-by: Krzysztof Kozlowski <k.kozlowski@...sung.com> > --- Reviewed-by: Alim Akhtar <alim.akhtar@...sung.com> > drivers/thermal/samsung/exynos_tmu.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/thermal/samsung/exynos_tmu.c b/drivers/thermal/samsung/exynos_tmu.c > index 1af7ea8dda71..f340e6edcb49 100644 > --- a/drivers/thermal/samsung/exynos_tmu.c > +++ b/drivers/thermal/samsung/exynos_tmu.c > @@ -608,7 +608,7 @@ static int exynos5440_tmu_initialize(struct platform_device *pdev) > { > struct exynos_tmu_data *data = platform_get_drvdata(pdev); > unsigned int trim_info = 0, con, rising_threshold; > - int ret = 0, threshold_code; > + int threshold_code; > int crit_temp = 0; > > /* > @@ -651,7 +651,8 @@ static int exynos5440_tmu_initialize(struct platform_device *pdev) > /* Clear the PMIN in the common TMU register */ > if (!data->id) > writel(0, data->base_second + EXYNOS5440_TMU_PMIN); > - return ret; > + > + return 0; > } > > static int exynos7_tmu_initialize(struct platform_device *pdev) > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-samsung-soc" in > the body of a message to majordomo@...r.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- Regards, Alim -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists