linux-kernel - Re: linux-next: manual merge of the tip tree with the crypto-current tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1444355547.2956.288.camel@decadent.org.uk>
Date:	Fri, 09 Oct 2015 02:52:27 +0100
From:	Ben Hutchings <ben@...adent.org.uk>
To:	Stephen Rothwell <sfr@...b.auug.org.au>,
	Thomas Gleixner <tglx@...utronix.de>,
	Ingo Molnar <mingo@...e.hu>, "H. Peter Anvin" <hpa@...or.com>,
	Peter Zijlstra <peterz@...radead.org>
Cc:	linux-next@...r.kernel.org, linux-kernel@...r.kernel.org,
	Dave Hansen <dave.hansen@...ux.intel.com>
Subject: Re: linux-next: manual merge of the tip tree with the
 crypto-current tree

On Fri, 2015-10-09 at 12:47 +1100, Stephen Rothwell wrote:
> Hi all,
> 
> Today's linux-next merge of the tip tree got a conflict in:
> 
>   arch/x86/crypto/camellia_aesni_avx_glue.c
> 
> between commit:
> 
>   92b279070dd6 ("crypto: camellia_aesni_avx - Fix CPU feature checks")
> 
> from the crypto-current tree and commit:
> 
>   d91cab78133d ("x86/fpu: Rename XSAVE macros")
> 
> from the tip tree.
> 
> I fixed it up (see below) and can carry the fix as necessary (no action
> is required).

> --- a/arch/x86/crypto/camellia_aesni_avx_glue.c
> +++ b/arch/x86/crypto/camellia_aesni_avx_glue.c
> @@@ -554,12 -554,8 +554,14 @@@ static int __init camellia_aesni_init(v
>   {
>         const char *feature_name;
>   
>  +      if (!cpu_has_avx || !cpu_has_aes || !cpu_has_osxsave) {
>  +              pr_info("AVX or AES-NI instructions are not detected.\n");
>  +              return -ENODEV;
>  +      }
>  +
>  +      if (!cpu_has_xfeatures(XSTATE_SSE | XSTATE_YMM, &feature_name)) {
> +       if (!cpu_has_xfeatures(XFEATURE_MASK_SSE | XFEATURE_MASK_YMM,
> +                               &feature_name)) {

Eh, that's not going to work.  You need to keep the second
if (!cpu_has_xfeatures()) condition and delete the first.

Ben.

>                 pr_info("CPU feature '%s' is not supported.\n", feature_name);
>                 return -ENODEV;
>         }
-- 
Ben Hutchings
If the facts do not conform to your theory, they must be disposed of.
Download attachment "signature.asc" of type "application/pgp-signature" (812 bytes)