linux-kernel - Re: [PATCH v4 12/26] ARM: pxa: magician: Rename charger cable detection EGPIOs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <5617278A.5060909@tul.cz>
Date:	Fri, 9 Oct 2015 04:33:46 +0200
From:	Petr Cvek <petr.cvek@....cz>
To:	Philipp Zabel <philipp.zabel@...il.com>, robert.jarzmik@...e.fr,
	daniel@...que.org, haojian.zhuang@...il.com, linux@....linux.org.uk
Cc:	linux-kernel@...r.kernel.org, linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH v4 12/26] ARM: pxa: magician: Rename charger cable
 detection EGPIOs

Dne 3.10.2015 v 14:38 Philipp Zabel napsal(a):
> Am Montag, den 28.09.2015, 23:32 +0200 schrieb Petr Cvek:
>> This patch renames EGPIOs, which are used for the charging cable
>> presence
>> and type detection. Old names did not correspond with an observed
>> functionality (on board_id 0x3a). The behavior is not:
>>
>> - AC charger
>> - USB charger
>> - Cable detection
>>
>> , but:
>>
>> - AC/USB type
>> - Cable detection1
>> - Cable detection2
>>
>> This patch fixes a possible typo in the bit offset for the cable
>> detection
>> EGPIO declaration, too.
>>
>> Signed-off-by: Petr Cvek <petr.cvek@....cz>
> 
> Just to be sure, please tell me what are the values of those three
> EGPIOs while
>   a) wall plug charger plugged in
>   b) usb cable connected to a host plugged in
>   c) no cable plugged in

usb	charger	none
====	=======	====
0xC0	0xC0	0xC0
0xA0	0xA0	0xA0
0x61	0x61	0x61
0x00	0x00	0x00
0x02	0x03	0x00	//first cable detection and charger type
0x3A	0x3A	0x3A	//send me your board_id
0x09	0x09	0x01	//second cable detection
0x04	0x04	0x04
0x00	0x00	0x00
0x00	0x00	0x00
0x00	0x00	0x00
0x00	0x00	0x00
0x00	0x00	0x00
0x00	0x00	0x00
0x00	0x00	0x00
0x00	0x00	0x00

I think the charger is original.

> 
> It could well be there are differences between our boards.

Well it is CPLD chip, so they can have different bitstreams (OT: I can think of many CPLD HDL enhancements :-D).

Cheers,
Petr
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/