linux-kernel - Re: [PATCH 10/44] kdbus: Use conditional operator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <05f501d10246$b5cd9350$2168b9f0$@alibaba-inc.com>
Date:	Fri, 09 Oct 2015 11:58:08 +0800
From:	"Hillf Danton" <hillf.zj@...baba-inc.com>
To:	"Sergei Zviagintsev" <sergei@...v.net>
Cc:	"'Greg Kroah-Hartman'" <gregkh@...uxfoundation.org>,
	"'Daniel Mack'" <daniel@...que.org>,
	"'David Herrmann'" <dh.herrmann@...glemail.com>,
	"'Djalal Harouni'" <tixxdz@...ndz.org>,
	"'linux-kernel'" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 10/44] kdbus: Use conditional operator

> 
> Signed-off-by: Sergei Zviagintsev <sergei@...v.net>
> ---
>  ipc/kdbus/names.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
> 
> diff --git a/ipc/kdbus/names.c b/ipc/kdbus/names.c
> index bf44ca3f12b6..6b31b38ac2ad 100644
> --- a/ipc/kdbus/names.c
> +++ b/ipc/kdbus/names.c
> @@ -438,10 +438,7 @@ static void kdbus_name_release_unlocked(struct kdbus_name_owner *owner)
>  		name->activator = NULL;
> 
>  	if (!primary || owner == primary) {
> -		next = kdbus_name_entry_first(name);
> -		if (!next)
> -			next = name->activator;
> -
> +		next = kdbus_name_entry_first(name) ?: name->activator;

Fix? Cleanup? What we gain, given no log message?
>  		if (next) {
>  			/* hand to next in queue */
>  			next->flags &= ~KDBUS_NAME_IN_QUEUE;
> --
> 1.8.3.1
> 
> 


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/