linux-kernel - Re: [PATCH v2 32/36] x86/entry: Micro-optimize compat fast syscall arg fetch

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151009073206.GB31859@gmail.com>
Date:	Fri, 9 Oct 2015 09:32:06 +0200
From:	Ingo Molnar <mingo@...nel.org>
To:	Andy Lutomirski <luto@...nel.org>
Cc:	x86@...nel.org, linux-kernel@...r.kernel.org,
	Brian Gerst <brgerst@...il.com>,
	Denys Vlasenko <dvlasenk@...hat.com>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Borislav Petkov <bp@...en8.de>
Subject: Re: [PATCH v2 32/36] x86/entry: Micro-optimize compat fast syscall
 arg fetch


* Andy Lutomirski <luto@...nel.org> wrote:

> we're following a 32-bit pointer, and the uaccess code isn't smart
> enough to figure out that the access_ok check isn't needed.
> 
> This saves about three cycles on a cache-hot fast syscall.

Another request: could you please stick the benchmarking code of the various x86 
system call variants into 'perf bench' - under tools/perf/bench/, so that 
measurements can be done on more hardware and can be reproduced easily?

I'd suggest we dedicate an entirely new benchmark family to it: 'perf bench x86' 
and then have:

   perf bench x86 syscall vdso
   perf bench x86 syscall int80
   perf bench x86 syscall vdso-compat

or so?

( I have some perf bench cleanups in -tip, so if you do this please base it on top 
  of that. )

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/