linux-kernel - Re: [PATCH] Fix cpupower reporting uninitialized values for offline cpus

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:	Fri, 09 Oct 2015 08:21:01 -0400
From:	Prarit Bhargava <prarit@...hat.com>
To:	Jacob Tanenbaum <jtanenba@...hat.com>, linux-pm@...r.kernel.org
CC:	trenn@...e.com, shreyas@...ux.vnet.ibm.com,
	rafael.j.wysock@...el.com, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] Fix cpupower reporting uninitialized values for offline
 cpus



On 10/01/2015 03:09 PM, Jacob Tanenbaum wrote:
> cpupower monitor reports uninitialized values for offline cpus
> 
> [root@...dl980g7-02 linux]# cpupower monitor
> ...
> 5472|   0|   1|******|******|******|******||******|******|******|| 0.00|  0.00|  0.00|  0.00|  0.00 *is offline
> 10567|   0| 159|******|******|******|******||******|******|******||  0.00|  0.00|  0.00|  0.00|  0.00 *is offline
> 1661206560|859272560| 150|******|******|******|******||******|******|******|| 0.00|  0.00|  0.00|  0.00|  0.00 *is offline
> 1661206560|943093104| 140|******|******|******|******||******|******|******|| 0.00|  0.00|  0.00|  0.00|  0.00 *is offline
> 
> because of this cpupower also holds the incorrect value for the number
> of physical packages in the machine
> 
> Changed cpupower to initialize the values of an offline cpu's socket and
> core to -1, warn the user that one or more cpus is/are
> offline and not print statistics for offline cpus.
> 
> Thomas Renninger suggested fixing the issue by checking for the
> existence of the topology files which the code already does, so I
> decided to use a check on if the cpu was online.

Thomas, any comment?

Looks good to me.  The description could be cleaned up a bit but I'll let the
maintainer decide if they want a new one.

Reviewed-by: Prarit Bhargava <prarit@...hat.com>

P.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/