linux-kernel - Re: [PATCH v4] clocksource/drivers/tango

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Fri, 9 Oct 2015 16:42:55 +0200
From:	Daniel Lezcano <daniel.lezcano@...aro.org>
To:	Marc Gonzalez <marc_gonzalez@...madesigns.com>,
	Thomas Gleixner <tglx@...utronix.de>
Cc:	Mason <slash.tmp@...e.fr>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH v4] clocksource/drivers/tango_xtal: Add new timer for
 Tango SoCs

On 10/09/2015 04:37 PM, Marc Gonzalez wrote:
> Sigma Designs Tango platforms provide a 27 MHz crystal oscillator.
> Use it for clocksource, sched_clock, and delay_timer.
>
> Signed-off-by: Marc Gonzalez <marc_gonzalez@...madesigns.com>
> ---

[ ... ]

> +
> +#define QUIT_IF(cond, fmt, ...) do if (cond) {		\
> +	static const char format[] __initconst = fmt;	\
> +	pr_err(format, ## __VA_ARGS__);			\
> +	return;						\
> +} while (0)

hmm ... forget something ?

> +
> +	ret = clocksource_register_hz(&tango_xtal, xtal_freq);
> +	if (ret != 0) {
> +		pr_err("%s: registration failed\n", np->full_name);
> +		return;
> +	}

missing line.

> +	sched_clock_register(read_sched_clock, 32, xtal_freq);
> +	register_current_timer_delay(&delay_timer);
> +}
> +
> +CLOCKSOURCE_OF_DECLARE(tango, "sigma,tick-counter", tango_clocksource_init);
>


-- 
  <http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs

Follow Linaro:  <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/