[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <CAPcyv4hVNykjWbmdpm4rN3Kf7GNPzNXxxH0jriMe2fpjNJYukg@mail.gmail.com>
Date: Fri, 9 Oct 2015 14:33:22 -0700
From: Dan Williams <dan.j.williams@...el.com>
To: Brian Norris <computersforpeace@...il.com>
Cc: Thomas Gleixner <tglx@...utronix.de>,
Ingo Molnar <mingo@...nel.org>,
"H. Peter Anvin" <hpa@...or.com>, linux-arch@...r.kernel.org,
"Kani, Toshimitsu" <toshi.kani@...com>,
"linux-nvdimm@...ts.01.org" <linux-nvdimm@...ts.01.org>,
"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
Russell King <rmk+kernel@....linux.org.uk>,
David Woodhouse <dwmw2@...radead.org>,
Christoph Hellwig <hch@....de>,
"linux-arm-kernel@...ts.infradead.org"
<linux-arm-kernel@...ts.infradead.org>,
linux-mtd@...ts.infradead.org
Subject: Re: [PATCH v2 19/25] pxa2xx-flash: switch from ioremap_cache to memremap
On Fri, Oct 2, 2015 at 10:51 AM, Brian Norris
<computersforpeace@...il.com> wrote:
> + linux-mtd
>
> On Fri, Jul 24, 2015 at 10:39:45PM -0400, Dan Williams wrote:
>> In preparation for deprecating ioremap_cache() convert its usage in
>> pxa2xx-flash to memremap.
>>
>> Cc: David Woodhouse <dwmw2@...radead.org>
>> Cc: Brian Norris <computersforpeace@...il.com>
>> Signed-off-by: Dan Williams <dan.j.williams@...el.com>
>> ---
>> drivers/mtd/maps/pxa2xx-flash.c | 4 ++--
>> 1 file changed, 2 insertions(+), 2 deletions(-)
>>
>> diff --git a/drivers/mtd/maps/pxa2xx-flash.c b/drivers/mtd/maps/pxa2xx-flash.c
>> index 12fa75df5008..758a8a7f86d9 100644
>> --- a/drivers/mtd/maps/pxa2xx-flash.c
>> +++ b/drivers/mtd/maps/pxa2xx-flash.c
>> @@ -71,8 +71,8 @@ static int pxa2xx_flash_probe(struct platform_device *pdev)
>> info->map.name);
>> return -ENOMEM;
>> }
>> - info->map.cached =
>> - ioremap_cache(info->map.phys, info->map.size);
>> + info->map.cached = memremap(info->map.phys, info->map.size,
>> + MEMREMAP_CACHE);
>
> Should the corresponding iounmap() be changed too? Looks like a pretty
> thin wrapper right now, but it seems like the API would suggest we do
> this anyway.
>
Yes, thanks for that catch, addressed in the next rev.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists