linux-kernel - Re: [PATCH 06/10] iommu/amd: Add functions copy_command_buffer/copy_event

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 10 Oct 2015 20:24:24 +0800
From:	Baoquan He <bhe@...hat.com>
To:	Joerg Roedel <joro@...tes.org>
Cc:	iommu@...ts.linux-foundation.org, kexec@...ts.infradead.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 06/10] iommu/amd: Add functions
 copy_command_buffer/copy_event_buffer

Hi Joerg,

On 09/29/15 at 06:04pm, Joerg Roedel wrote:
> On Thu, Sep 24, 2015 at 02:37:32PM +0800, Baoquan He wrote:
> > Copy command buffer and event buffer from the old to kdump kernel.
> > 
> > Still there are 2 problems:
> >   1) Not very sure if this is necessary. If do not copy the old command buffer, and
> > only set the newly allocated command buffer, is there anything wrong?
> 
> No, there is no need to copy command and event buffers. Just make sure
> they get re-initialized and flush all iommu caches after setting the new
> device table.

Thanks for your reviewing.

I did a lot of tests. Seems that it doesn't matter with copy or without
a copy. And it's also OK even completely ignore the command buffer and
event log handling here.

Thanks
Baoquan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/