linux-kernel - Re: [PATCHv4 RESEND] staging: vme

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 11 Oct 2015 07:53:01 +0800
From:	kbuild test robot <lkp@...el.com>
To:	Dmitry Kalinkin <dmitry.kalinkin@...il.com>
Cc:	kbuild-all@...org, Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Martyn Welch <martyn@...chs.me.uk>,
	Manohar Vanga <manohar.vanga@...il.com>,
	devel@...verdev.osuosl.org,
	Dmitry Kalinkin <dmitry.kalinkin@...il.com>,
	linux-kernel@...r.kernel.org, Igor Alekseev <igor.alekseev@...p.ru>
Subject: Re: [PATCHv4 RESEND] staging: vme_user: provide DMA functionality

Hi Dmitry,

[auto build test WARNING on driver-core/driver-core-next -- if it's inappropriate base, please ignore]

config: x86_64-randconfig-x010-201541 (attached as .config)
reproduce:
        # save the attached .config to linux build tree
        make ARCH=x86_64 

Note: it may well be a FALSE warning. FWIW you are at least aware of it now.
http://gcc.gnu.org/wiki/Better_Uninitialized_Warnings

All warnings (new ones prefixed by >>):

   drivers/staging/vme/devices/vme_user.c: In function 'vme_user_ioctl.isra.4':
>> drivers/staging/vme/devices/vme_user.c:324:7: warning: 'dest' may be used uninitialized in this function [-Wmaybe-uninitialized]
      ret = vme_dma_list_add(dma_list, src, dest, hw_len);
          ^
   drivers/staging/vme/devices/vme_user.c:296:52: note: 'dest' was declared here
      struct vme_dma_attr *pci_attr, *vme_attr, *src, *dest;
                                                       ^
>> drivers/staging/vme/devices/vme_user.c:324:7: warning: 'src' may be used uninitialized in this function [-Wmaybe-uninitialized]
      ret = vme_dma_list_add(dma_list, src, dest, hw_len);
          ^
   drivers/staging/vme/devices/vme_user.c:296:46: note: 'src' was declared here
      struct vme_dma_attr *pci_attr, *vme_attr, *src, *dest;
                                                 ^

vim +/dest +324 drivers/staging/vme/devices/vme_user.c

   308			if (!pci_attr) {
   309				vme_dma_free_attribute(vme_attr);
   310				return -ENOMEM;
   311			}
   312	
   313			switch (dma_op->dir) {
   314			case VME_DMA_MEM_TO_VME:
   315				src = pci_attr;
   316				dest = vme_attr;
   317				break;
   318			case VME_DMA_VME_TO_MEM:
   319				src = vme_attr;
   320				dest = pci_attr;
   321				break;
   322			}
   323	
 > 324			ret = vme_dma_list_add(dma_list, src, dest, hw_len);
   325	
   326			/*
   327			 * XXX VME API doesn't mention whether we should keep
   328			 * attributes around
   329			 */
   330			vme_dma_free_attribute(vme_attr);
   331			vme_dma_free_attribute(pci_attr);
   332	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (21590 bytes)