linux-kernel - drivers/media/i2c/adv7604.c:1853:9: error: implicit declaration of function 'v4l2_subdev_get_try

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [day] [month] [year] [list]
Date:	Sun, 11 Oct 2015 10:19:09 +0800
From:	kbuild test robot <fengguang.wu@...el.com>
To:	Hans Verkuil <hans.verkuil@...co.com>
Cc:	kbuild-all@...org, linux-kernel@...r.kernel.org,
	Mauro Carvalho Chehab <m.chehab@...sung.com>,
	linux-media@...r.kernel.org
Subject: drivers/media/i2c/adv7604.c:1853:9: error: implicit declaration of
 function 'v4l2_subdev_get_try_format'

Hi Hans,

FYI, the error/warning still remains.

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   4a06c8ac2fb3ef484579ce44f9b809bd310fad48
commit: 85756a069c55e0315ac5990806899cfb607b987f [media] cobalt: add new driver
date:   5 months ago
config: x86_64-randconfig-s5-10110927 (attached as .config)
reproduce:
        git checkout 85756a069c55e0315ac5990806899cfb607b987f
        # save the attached .config to linux build tree
        make ARCH=x86_64 

All errors (new ones prefixed by >>):

   drivers/media/i2c/adv7604.c: In function 'adv76xx_get_format':
>> drivers/media/i2c/adv7604.c:1853:9: error: implicit declaration of function 'v4l2_subdev_get_try_format' [-Werror=implicit-function-declaration]
      fmt = v4l2_subdev_get_try_format(sd, cfg, format->pad);
            ^
   drivers/media/i2c/adv7604.c:1853:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
      fmt = v4l2_subdev_get_try_format(sd, cfg, format->pad);
          ^
   drivers/media/i2c/adv7604.c: In function 'adv76xx_set_format':
   drivers/media/i2c/adv7604.c:1882:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
      fmt = v4l2_subdev_get_try_format(sd, cfg, format->pad);
          ^
   cc1: some warnings being treated as errors
--
   drivers/media/i2c/adv7842.c: In function 'adv7842_get_format':
>> drivers/media/i2c/adv7842.c:2093:9: error: implicit declaration of function 'v4l2_subdev_get_try_format' [-Werror=implicit-function-declaration]
      fmt = v4l2_subdev_get_try_format(sd, cfg, format->pad);
            ^
   drivers/media/i2c/adv7842.c:2093:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
      fmt = v4l2_subdev_get_try_format(sd, cfg, format->pad);
          ^
   drivers/media/i2c/adv7842.c: In function 'adv7842_set_format':
   drivers/media/i2c/adv7842.c:2125:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
      fmt = v4l2_subdev_get_try_format(sd, cfg, format->pad);
          ^
   cc1: some warnings being treated as errors
--
   drivers/media/i2c/adv7511.c: In function 'adv7511_get_fmt':
>> drivers/media/i2c/adv7511.c:859:9: error: implicit declaration of function 'v4l2_subdev_get_try_format' [-Werror=implicit-function-declaration]
      fmt = v4l2_subdev_get_try_format(sd, cfg, format->pad);
            ^
   drivers/media/i2c/adv7511.c:859:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
      fmt = v4l2_subdev_get_try_format(sd, cfg, format->pad);
          ^
   drivers/media/i2c/adv7511.c: In function 'adv7511_set_fmt':
   drivers/media/i2c/adv7511.c:910:7: warning: assignment makes pointer from integer without a cast [-Wint-conversion]
      fmt = v4l2_subdev_get_try_format(sd, cfg, format->pad);
          ^
   cc1: some warnings being treated as errors

vim +/v4l2_subdev_get_try_format +1853 drivers/media/i2c/adv7604.c

539b33b0 Laurent Pinchart 2014-01-26  1837  }
539b33b0 Laurent Pinchart 2014-01-26  1838  
f7234138 Hans Verkuil     2015-03-04  1839  static int adv76xx_get_format(struct v4l2_subdev *sd,
f7234138 Hans Verkuil     2015-03-04  1840  			      struct v4l2_subdev_pad_config *cfg,
539b33b0 Laurent Pinchart 2014-01-26  1841  			      struct v4l2_subdev_format *format)
539b33b0 Laurent Pinchart 2014-01-26  1842  {
b44b2e06 Pablo Anton      2015-02-03  1843  	struct adv76xx_state *state = to_state(sd);
539b33b0 Laurent Pinchart 2014-01-26  1844  
539b33b0 Laurent Pinchart 2014-01-26  1845  	if (format->pad != state->source_pad)
539b33b0 Laurent Pinchart 2014-01-26  1846  		return -EINVAL;
539b33b0 Laurent Pinchart 2014-01-26  1847  
b44b2e06 Pablo Anton      2015-02-03  1848  	adv76xx_fill_format(state, &format->format);
539b33b0 Laurent Pinchart 2014-01-26  1849  
539b33b0 Laurent Pinchart 2014-01-26  1850  	if (format->which == V4L2_SUBDEV_FORMAT_TRY) {
539b33b0 Laurent Pinchart 2014-01-26  1851  		struct v4l2_mbus_framefmt *fmt;
539b33b0 Laurent Pinchart 2014-01-26  1852  
f7234138 Hans Verkuil     2015-03-04 @1853  		fmt = v4l2_subdev_get_try_format(sd, cfg, format->pad);
539b33b0 Laurent Pinchart 2014-01-26  1854  		format->format.code = fmt->code;
539b33b0 Laurent Pinchart 2014-01-26  1855  	} else {
539b33b0 Laurent Pinchart 2014-01-26  1856  		format->format.code = state->format->code;
539b33b0 Laurent Pinchart 2014-01-26  1857  	}
539b33b0 Laurent Pinchart 2014-01-26  1858  
539b33b0 Laurent Pinchart 2014-01-26  1859  	return 0;
539b33b0 Laurent Pinchart 2014-01-26  1860  }
539b33b0 Laurent Pinchart 2014-01-26  1861  

:::::: The code at line 1853 was first introduced by commit
:::::: f7234138f14c2296c5eb6b8224abe00b507faf3f [media] v4l2-subdev: replace v4l2_subdev_fh by v4l2_subdev_pad_config

:::::: TO: Hans Verkuil <hans.verkuil@...co.com>
:::::: CC: Mauro Carvalho Chehab <mchehab@....samsung.com>

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/octet-stream" (26446 bytes)