linux-kernel - Re: [PATCH] iio: mxs-lradc: Fix temperature offset

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <561A6C2E.4080800@kernel.org>
Date:	Sun, 11 Oct 2015 15:03:26 +0100
From:	Jonathan Cameron <jic23@...nel.org>
To:	Marek Vasut <marex@...x.de>,
	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
Cc:	Lars-Peter Clausen <lars@...afoo.de>, linux-iio@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] iio: mxs-lradc: Fix temperature offset

On 07/10/15 00:13, Marek Vasut wrote:
> On 10/06/2015 16:22, Alexandre Belloni wrote:
>> 0° Kelvin is actually −273.15°C, not -272.15°C. Fix the temperature offset.
>>
>> Reported-by: Janusz Użycki <j.uzycki@...romaelectronics.com>
>> Signed-off-by: Alexandre Belloni <alexandre.belloni@...e-electrons.com>
> 
> Nice find :-)
> 
> Acked-by: Marek Vasut <marex@...x.de>
Ah, missed this when applying.  Have added your Ack to the V2 and will
push it out later.

J
> 
> (I am using different MUA, please pardon the possible issues)
> 
>> ---
>>   drivers/staging/iio/adc/mxs-lradc.c | 6 +++---
>>   1 file changed, 3 insertions(+), 3 deletions(-)
>>
>> diff --git a/drivers/staging/iio/adc/mxs-lradc.c b/drivers/staging/iio/adc/mxs-lradc.c
>> index 3f7715c9968b..67bfa54c4fb1 100644
>> --- a/drivers/staging/iio/adc/mxs-lradc.c
>> +++ b/drivers/staging/iio/adc/mxs-lradc.c
>> @@ -916,10 +916,10 @@ static int mxs_lradc_read_raw(struct iio_dev *iio_dev,
>>           if (chan->type == IIO_TEMP) {
>>               /* The calculated value from the ADC is in Kelvin, we
>>                * want Celsius for hwmon so the offset is
>> -             * -272.15 * scale
>> +             * -273.15 * scale
>>                */
>> -            *val = -1075;
>> -            *val2 = 691699;
>> +            *val = -1079;
>> +            *val2 = 644268;
>>
>>               return IIO_VAL_INT_PLUS_MICRO;
>>           }
>>
> 
> -- 
> To unsubscribe from this list: send the line "unsubscribe linux-iio" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/