linux-kernel - Re: [PATCH v4] scsi: ufs: add ioctl interface for query request

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <5532251.sHP7i3bdrH@wuerfel>
Date:	Sun, 11 Oct 2015 21:13:17 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Yaniv Gardi <ygardi@...eaurora.org>
Cc:	James.Bottomley@...senpartnership.com,
	linux-kernel@...r.kernel.org, linux-scsi@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, santoshsy@...il.com,
	linux-scsi-owner@...r.kernel.org, subhashj@...eaurora.org,
	gbroner@...eaurora.org, draviv@...eaurora.org,
	Noa Rubens <noag@...eaurora.org>,
	Raviv Shvili <rshvili@...eaurora.org>,
	Vinayak Holikatti <vinholikatti@...il.com>,
	"James E.J. Bottomley" <JBottomley@...n.com>,
	"open list:ABI/API" <linux-api@...r.kernel.org>
Subject: Re: [PATCH v4] scsi: ufs: add ioctl interface for query request

On Sunday 11 October 2015 14:22:12 Yaniv Gardi wrote:
>   * @cookie: cookie data
> @@ -5106,6 +5308,10 @@ static struct scsi_host_template ufshcd_driver_template = {
>         .eh_device_reset_handler = ufshcd_eh_device_reset_handler,
>         .eh_host_reset_handler   = ufshcd_eh_host_reset_handler,
>         .eh_timed_out           = ufshcd_eh_timed_out,
> +       .ioctl                  = ufshcd_ioctl,
> +#ifdef CONFIG_COMPAT
> +       .compat_ioctl           = ufshcd_ioctl,
> +#endif
>         .this_id                = -1,
>         .sg_tablesize           = SG_ALL,
>         .cmd_per_lun            = UFSHCD_CMD_PER_LUN,
> 

I think I commented before that the #ifdef here is not needed and should
just be removed. Otherwise it looks ok to me now.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/