linux-kernel - Re: [PATCH v2] ALSA: bebob: constify snd_bebob_rate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.2.02.1510110807340.2057@localhost6.localdomain6>
Date:	Sun, 11 Oct 2015 08:08:37 +0200 (CEST)
From:	Julia Lawall <julia.lawall@...6.fr>
To:	Takashi Sakamoto <o-takashi@...amocchi.jp>
cc:	kernel-janitors@...r.kernel.org, alsa-devel@...a-project.org,
	Clemens Ladisch <clemens@...isch.de>,
	linux-kernel@...r.kernel.org, Takashi Iwai <tiwai@...e.com>
Subject: Re: [PATCH v2] ALSA: bebob: constify snd_bebob_rate_spec
 structures



On Sun, 11 Oct 2015, Takashi Sakamoto wrote:

> Hi,
> 
> On Oct 11 2015 06:24, Julia Lawall wrote:
> > The structures of type snd_bebob_clock_spec, snd_bebob_rate_spec,
> > snd_bebob_meter_spec, and snd_bebob_spec are never modified after they are
> > initialized.  Make them all const.
> > 
> > Done with the help of Coccinelle.
> > 
> > Signed-off-by: Julia Lawall <Julia.Lawall@...6.fr>
> > 
> > ---
> > 
> > v2: extend to snd_bebob_clock_spec, snd_bebob_meter_spec, and 
> > snd_bebob_spec structures.
> > 
> >  sound/firewire/bebob/bebob.c           |    2 +-
> >  sound/firewire/bebob/bebob.h           |   32 ++++++++++++++++----------------
> >  sound/firewire/bebob/bebob_focusrite.c |   26 +++++++++++++-------------
> >  sound/firewire/bebob/bebob_maudio.c    |   32 ++++++++++++++++----------------
> >  sound/firewire/bebob/bebob_pcm.c       |    2 +-
> >  sound/firewire/bebob/bebob_proc.c      |    6 +++---
> >  sound/firewire/bebob/bebob_stream.c    |    6 +++---
> >  sound/firewire/bebob/bebob_terratec.c  |   10 +++++-----
> >  sound/firewire/bebob/bebob_yamaha.c    |    6 +++---
> >  9 files changed, 61 insertions(+), 61 deletions(-)
> 
> Tested-by: Takashi Sakamoto <o-takashi@...amocchi.jp>
> Reviewed-by: Takashi Sakamoto <o-takashi@...amocchi.jp>
> 
> Thank you to include my extra request and spend more time for this patch ;)
> 
> But I prefer to change the title of this patch to 'ALSA: bebob: constify
> some structures because they are never modified' or something like it
> because this patch is not only for 'struct snd_bebob_rate_spec'.

Sorry not to have paid attention to that.  I will send it again.

julia
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/