linux-kernel - Re: [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to suspending

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20151012065323.GA3558@piout.net>
Date:	Mon, 12 Oct 2015 08:53:23 +0200
From:	Alexandre Belloni <alexandre.belloni@...e-electrons.com>
To:	Wenyou Yang <wenyou.yang@...el.com>
Cc:	Alessandro Zummo <a.zummo@...ertech.it>,
	Nicolas Ferre <nicolas.ferre@...el.com>,
	Ludovic Desroches <ludovic.desroches@...el.com>,
	rtc-linux@...glegroups.com, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] rtc: at91rm9200: clear RTC alarm status flag prior to
 suspending

Hi Wenyou,

On 12/10/2015 at 09:17:57 +0800, Wenyou Yang wrote :
> This patch is to clear the RTC alarm status flag prior to suspending
> to avoid the erroneous wake-up activity.
> 

Is this a new issue appearing with the sama5d2 or was it present from
the beginning?

> Signed-off-by: Wenyou Yang <wenyou.yang@...el.com>
> ---
> 
>  drivers/rtc/rtc-at91rm9200.c |    2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/rtc/rtc-at91rm9200.c b/drivers/rtc/rtc-at91rm9200.c
> index cb62e21..b60fd47 100644
> --- a/drivers/rtc/rtc-at91rm9200.c
> +++ b/drivers/rtc/rtc-at91rm9200.c
> @@ -495,6 +495,8 @@ static int at91_rtc_suspend(struct device *dev)
>  	/* this IRQ is shared with DBGU and other hardware which isn't
>  	 * necessarily doing PM like we are...
>  	 */
> +	at91_rtc_write(AT91_RTC_SCCR, AT91_RTC_ALARM);
> +
>  	at91_rtc_imr = at91_rtc_read_imr()
>  			& (AT91_RTC_ALARM|AT91_RTC_SECEV);
>  	if (at91_rtc_imr) {
> -- 
> 1.7.9.5
> 

-- 
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/