linux-kernel - Re: [PATCH] md: fix 32-bit build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 12 Oct 2015 11:30:11 +0200
From:	Arnd Bergmann <arnd@...db.de>
To:	Neil Brown <neilb@...e.com>
Cc:	linux-raid@...r.kernel.org, linux-kernel@...r.kernel.org,
	Goldwyn Rodrigues <rgoldwyn@...e.com>,
	linux-arm-kernel@...ts.infradead.org
Subject: Re: [PATCH] md: fix 32-bit build warning

On Monday 12 October 2015 15:59:27 Neil Brown wrote:
> > diff --git a/drivers/md/md.c b/drivers/md/md.c
> > index 7fff1e6884d6..e13f72a3b561 100644
> > --- a/drivers/md/md.c
> > +++ b/drivers/md/md.c
> > @@ -8987,9 +8987,9 @@ static void check_sb_changes(struct mddev *mddev, struct md_rdev *rdev)
> >  
> >       /* recovery_cp changed */
> >       if (le64_to_cpu(sb->resync_offset) != mddev->recovery_cp) {
> > -             pr_info("%s:%d recovery_cp changed from %lu to %lu\n", __func__,
> > -                             __LINE__, mddev->recovery_cp,
> > -                             (unsigned long) le64_to_cpu(sb->resync_offset));
> > +             pr_info("%s:%d recovery_cp changed from %llu to %llu\n", __func__,
> > +                             __LINE__, (u64)mddev->recovery_cp,
> > +                             (u64) le64_to_cpu(sb->resync_offset));
> >               mddev->recovery_cp = le64_to_cpu(sb->resync_offset);
> >       }
> >  
> 
> Thanks, but is this really right?
> I think u64 is "unsigned long" on 64bit.
> I have always used (unsigned long long) when I want to use %llu on
> sector_t.
> 
> How confident are you of using "u64" ?

Very confident ;-)

This used to not work until some linux-2.6 version when we changed all
architectures to use asm-generic/int-ll64.h in the kernel, because
a lot of code relied on printing u64 variables using %lld.

I tend to use u64 for things like this because it's shorter than
'unsigned long long'.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/